opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-2.9'

Browse Source 
* stable-2.9:
  Describe 'No Differences' label in review UI documentation
  Describe red bar for line gaps in review UI documentation
  Link new review UI documentation from 2.9 release notes
  Add 'View Plugins' global capability that allows to list plugins
  Keep new draft comment expanded if expand all comments is set
  Allow to download reposize.sh script from Gerrit
  Link new review UI documentation from new change screen welcome popup
  Document major differences between old and new review UI
  Describe keyboard shortcuts in review UI documentation
  Describe navigation in patch file in review UI documentation
  Describe Vim-like search in review UI documentation
  Upgrade jgit to v3.4.0.201405051725-m7
  Link 2.8.5 release notes from 2.9 release notes
  Review UI docs: Update screenshot about navigation to show all arrows
  Review UI Docs: Remove note about double-click not adding new comments
  Describe diff preferences in review UI documentation
  Add new screenshot that shows the result after replying with done
  Describe navigation between patches in review UI documentation
  Describe patch set selection and patch download in review UI docs

Conflicts:
	lib/jgit/BUCK

Change-Id: I3b63776c5eed46406c93996b190f968e294f84eb
This commit is contained in:
David Pursehouse
2014-05-12 12:33:42 +09:00
parent f6e27e6e55 01280cc045
commit b9f568523e
38 changed files with 345 additions and 360 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java
View File

@@ -14,9 +14,9 @@
package com.google.gerrit.client;
import static com.google.gerrit.common.data.GlobalCapability.ADMINISTRATE_SERVER;
import static com.google.gerrit.common.data.GlobalCapability.CREATE_GROUP;
import static com.google.gerrit.common.data.GlobalCapability.CREATE_PROJECT;
import static com.google.gerrit.common.data.GlobalCapability.VIEW_PLUGINS;
import com.google.gerrit.client.account.AccountApi;
import com.google.gerrit.client.account.AccountCapabilities;
@@ -671,14 +671,14 @@ public class Gerrit implements EntryPoint {
PageLinks.ADMIN_CREATE_GROUP,
peopleBar.getWidgetIndex(groupsListMenuItem) + 1);
}
if (result.canPerform(ADMINISTRATE_SERVER)) {
if (result.canPerform(VIEW_PLUGINS)) {
insertLink(pluginsBar, C.menuPluginsInstalled(),
PageLinks.ADMIN_PLUGINS, 0);
menuLeft.insert(pluginsBar, C.menuPlugins(),
menuLeft.getWidgetIndex(peopleBar) + 1);
}
}
}, CREATE_PROJECT, CREATE_GROUP, ADMINISTRATE_SERVER);
}, CREATE_PROJECT, CREATE_GROUP, VIEW_PLUGINS);
}
if (getConfig().isDocumentationAvailable()) {