opendev/gerrit
Code Issues Proposed changes

Fix GWT Super Dev Mode compilation by giving more specific source paths

Browse Source 
The source path in GerritGwtUICommon.gwt.xml is including too many
files under "client", which causes compilation errors when running GWT's
Super Dev Mode in Eclipse with the "-strict" flag. Fix it by specifying
the actual set of files.

Change-Id: Ifa718f5aeebabd31da432be9626cf4c356170afa
This commit is contained in:
Michael Zhou
2016-08-11 22:57:56 -04:00
parent 96dd7e15e2
commit bb9286420c
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
gerrit-gwtui-common/src/main/java/com/google/gerrit/GerritGwtUICommon.gwt.xml
View File

@@ -22,5 +22,22 @@
<inherits name='com.google.gwtexpui.globalkey.GlobalKey'/>
<inherits name='com.google.gwtexpui.progress.Progress'/>
<inherits name='com.google.gwtexpui.safehtml.SafeHtml'/>
<source path='client' />
<source path='client'>
<include name='AccountFormatter.java'/>
<include name='CommonConstants.java'/>
<include name='CommonMessages.java'/>
<include name='DateFormatter.java'/>
<include name='GerritUiExtensionPoint.java'/>
<include name='RelativeDateFormatter.java'/>
<include name='Resources.java'/>
<include name='CommonConstants.properties'/>
<include name='CommonMessages.properties'/>
<include name='info/*.java'/>
<include name='rpc/NativeMap.java'/>
<include name='rpc/Natives.java'/>
<include name='rpc/NativeString.java'/>
<include name='rpc/TransformCallback.java'/>
<include name='ui/HighlightSuggestion.java'/>
<include name='ui/RemoteSuggestOracle.java'/>
</source>
</module>