opendev/gerrit
Code Issues Proposed changes

Revert marking merged or abandoned changes in related changes

Browse Source 
This incurs database lookups on every commit returned from the RevWalk
that does not have an open change associated with it. Typically this
is not very many, because the walk is limited to the current branch
tip.

However, there is very bad worst-case behavior in the case of
reviewing a merge that pulls in a long side branch whose merge base
with tip is far back in history:

  M
  |\
  T \
  | B1000
 ... ...
  | B1
  |/
  O

In this case, we incur a thousand distinct database lookups to see
whether B1..B1000 have changes associated with them. In practice this
is a serious performance regression on some large repositories.

The original changes were a very useful bugfix, but it needs a more
efficient implementation.

This reverts the following commits:
d3b6e1d531
72d9193f62

Change-Id: Ia3d4b200e677bca24fcd8fa9a4629bb406e90998
This commit is contained in:
Dave Borowitz
2015-03-13 13:56:41 -07:00
parent 42ed004363
commit bbaea3fb34
6 changed files with 1 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Documentation/rest-api-changes.txt
View File

@@ -3918,7 +3918,6 @@ a related change and commit.
|===========================
|Field Name ||Description
|`change_id` |optional|The Change-Id of the change.
|`status` |optional|The status of the change.
|`commit` ||The commit as a
link:#commit-info[CommitInfo] entity.
|`_change_number` |optional|The change number.