opendev/gerrit
Code Issues Proposed changes

Fix change-star in change view

Browse Source 
Regression caused by 08ab3aa2 -- the change-star element no longer makes
API calls, instead relying on the parent component.

Bug: Issue 9511
Change-Id: I26faee7ab9158687ec939c48592f3a263cffc93e
This commit is contained in:
Kasper Nilsson 2018-08-01 10:23:23 -07:00
parent e27a404a3e
commit bbd286781c
3 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html
View File

@ -362,7 +362,9 @@ limitations under the License.
<div class="headerTitle">
<gr-change-star
id="changeStar"
change="{{_change}}" hidden$="[[!_loggedIn]]"></gr-change-star>
change="{{_change}}"
on-toggle-star="_handleToggleStar"
hidden$="[[!_loggedIn]]"></gr-change-star>
<div class="changeStatuses">
<template is="dom-repeat" items="[[_changeStatuses]]" as="status">
<gr-change-status

5
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
View File

@ -1623,5 +1623,10 @@
_resetReplyOverlayFocusStops() {
this.$.replyOverlay.setFocusStops(this.$.replyDialog.getFocusStops());
},
_handleToggleStar(e) {
this.$.restAPI.saveChangeStarred(e.detail.change._number,
e.detail.starred);
},
});
})();

13
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
View File

@ -1735,5 +1735,18 @@ limitations under the License.
assert.isTrue(setStub.calledOnce);
assert.isTrue(setStub.calledWith(101, 'test-project'));
});
test('_handleToggleStar called when star is tapped', () => {
element._change = {
owner: {_account_id: 1},
starred: false,
};
element._loggedIn = true;
const stub = sandbox.stub(element, '_handleToggleStar');
flushAsynchronousOperations();
MockInteractions.tap(element.$.changeStar.$$('button'));
assert.isTrue(stub.called);
});
});
</script>