opendev/gerrit
Code Issues Proposed changes

GitWebType: remove redundant 'else' block

Browse Source 
The 'type' is set to null when name is 'disabled' and in all
other cases that don't match the previous conditions.

This results in a warning from Findbugs: "This method uses the same
code to implement two branches of a conditional branch."

Remove the redundant condition.

Change-Id: I042dc02ef05e9ce39fdbe3ea8553d9c42ef3e521
This commit is contained in:
David Pursehouse
2015-03-13 15:59:50 +09:00
parent 7aad161bf3
commit bcb00735e4
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-common/src/main/java/com/google/gerrit/common/data/GitWebType.java
View File

@@ -47,10 +47,6 @@ public class GitWebType {
type = new GitWebType(); type = new GitWebType();
// The custom name is not defined, let's keep the old style of using GitWeb // The custom name is not defined, let's keep the old style of using GitWeb
type.setLinkName("gitweb"); type.setLinkName("gitweb");
} else if (name.equalsIgnoreCase("disabled")) {
type = null;
} else { } else {
type = null; type = null;
} }