opendev/gerrit
Code Issues Proposed changes

ChangeInfo: Be consistent with native java script

Browse Source 
The other native methods returning a boolean value use ` X ? true : false`,
so be consistent with them.

Change-Id: I639ae1772b9b7f5844257b35bd8ac3ff48d94455
This commit is contained in:
Stefan Beller
2015-07-28 09:45:09 -07:00
parent b009b5b4b9
commit bce3b84b79
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java
View File

@@ -93,7 +93,7 @@ public class ChangeInfo extends JavaScriptObject {
public final native String branch() /*-{ return this.branch; }-*/;
public final native String topic() /*-{ return this.topic; }-*/;
public final native String changeId() /*-{ return this.change_id; }-*/;
public final native boolean mergeable() /*-{ return this.mergeable || false; }-*/;
public final native boolean mergeable() /*-{ return this.mergeable ? true : false; }-*/;
public final native int insertions() /*-{ return this.insertions; }-*/;
public final native int deletions() /*-{ return this.deletions; }-*/;
private final native String statusRaw() /*-{ return this.status; }-*/;