opendev/gerrit
Code Issues Proposed changes

Honor user's syntax coloring preference in unified view

Browse Source 
We used to disable syntax coloring in the unified view, because it
conflicted with the unified view's coloring of added lines with
green text and deleted lines with red text.  We used to do that
text coloring here because it matches what `git diff --color`
does on the command line, and because our table didn't color out
rows fully, resulting in a messy display.

We've since fixed the background coloring of our table rows,
and even support syntax coloring on top of that, and intraline
difference coloring, and it all looks just fine when viewing say
a Bourne shell script.

So stop messing with the user's settings and just honor them exactly
as they are.

Bug: issue 671
Change-Id: I3b7f21efb558429a7fd25158f2d62834c2ba56bf
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2010-08-21 12:51:15 -07:00
parent 3a89c2a278
commit bd000eb07c
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java
View File

@@ -80,9 +80,6 @@ public abstract class PatchScreen extends Screen implements
public Unified(final Patch.Key id, final int patchIndex,
final PatchSetDetail patchSetDetail, final PatchTable patchTable) {
super(id, patchIndex, patchSetDetail, patchTable);
final AccountDiffPreference dp = settingsPanel.getValue();
dp.setSyntaxHighlighting(false);
settingsPanel.setValue(dp);
}
@Override