opendev/gerrit
Code Issues Proposed changes

Show 'Related Changes' tab only if there are related changes

Browse Source 
This is consistent with the other tabs that are only shown if they
contain changes.

Change-Id: I131ac18234f3f9e64e6c364fd63e819eb9202bda
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-11-27 08:00:08 +01:00
parent 6b018061eb
commit bd285c6347
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java
View File

@@ -171,22 +171,30 @@ class RelatedChanges extends TabPanel {
}
private void setForOpenChange(final ChangeInfo info, final String revision) {
relatedChangesTab = createTab(Resources.C.relatedChanges(),
Resources.C.relatedChangesTooltip());
ChangeApi.revision(info.legacy_id().get(), revision).view("related")
.get(new AsyncCallback<RelatedInfo>() {
@Override
public void onSuccess(RelatedInfo result) {
relatedChangesTab.setTitle(Resources.M.relatedChanges(result.changes().length()));
relatedChangesTab.setChanges(info.project(), revision, result.changes());
if (result.changes().length() > 0) {
getTab().setTitle(Resources.M.relatedChanges(result.changes().length()));
getTab().setChanges(info.project(), revision, result.changes());
}
}
@Override
public void onFailure(Throwable err) {
relatedChangesTab.setTitle(
getTab().setTitle(
Resources.M.relatedChanges(Resources.C.notAvailable()));
relatedChangesTab.setError(err.getMessage());
getTab().setError(err.getMessage());
}
private RelatedChangesTab getTab() {
if (relatedChangesTab == null) {
relatedChangesTab =
createTab(Resources.C.relatedChanges(),
Resources.C.relatedChangesTooltip());
}
return relatedChangesTab;
}
});