opendev/gerrit
Code Issues Proposed changes

Handle NoSuchChangeException in 'review' SSH command

Browse Source 
A NoSuchChangeException in the 'review' SSH command resulted in an
'internal server error'. Now a proper error message is printed out.

A NoSuchChangeException e.g. occurs if a user tries to publish a
draft change that is not visible to him.

Change-Id: I42b5491f98b2de59794abe7e2f4e483439a141e2
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-02-13 15:29:49 +01:00
parent 0f9e749483
commit bd5f2040f8
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java
View File

@@ -182,6 +182,9 @@ public class ReviewCommand extends BaseCommand {
} catch (UnloggedFailure e) {
ok = false;
writeError("error: " + e.getMessage() + "\n");
} catch (NoSuchChangeException e) {
ok = false;
writeError("no such change " + patchSetId.getParentKey().get());
} catch (Exception e) {
ok = false;
writeError("fatal: internal server error while approving "