opendev/gerrit
Code Issues Proposed changes

Remove getReviewDbProvider() from RequestContext interface

Browse Source 
This method was the source of lots of complexity in reopening ReviewDbs
in background threads and Guice request scopes. Thankfully we don't need
it anymore.

Change-Id: Ifd76484bcf308362c24ca7df38b07f604476c932
This commit is contained in:
Dave Borowitz
2018-12-14 15:30:21 -08:00
parent 9613e76ff6
commit bd64916573
30 changed files with 19 additions and 424 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/com/google/gerrit/server/util/RequestContext.java
View File

@@ -14,9 +14,7 @@
package com.google.gerrit.server.util;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.CurrentUser;
import com.google.inject.Provider;
/**
* The RequestContext is an interface exposing the fields that are needed by the GerritGlobalModule
@@ -24,6 +22,4 @@ import com.google.inject.Provider;
*/
public interface RequestContext {
CurrentUser getUser();
Provider<ReviewDb> getReviewDbProvider();
}