opendev/gerrit
Code Issues Proposed changes

Show dependency list when closed change is needed by an open change

Browse Source 
Commit 7cc8ef4b01 made the dependency
list for an open change automatically shown if this change was
needed by another open change. However if the change was closed the
dependency list was not automatically opened if there was an open
change depending on it.

This is bad for submitting a change series, where you review and submit
one change and then you want to continue reviewing the next change in
this series. By submitting the first change it gets closed, causing its
dependency list to get closed. Now to navigate to the next change in
the series first the dependency list has to be opened manually again.

Change-Id: Ie8f222bd6c3143a71eb702b24387c19c9f282f85
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-07-19 12:17:42 +02:00
parent 5cd88705ba
commit bd806d2b90
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
View File

@@ -306,12 +306,12 @@ public class ChangeScreen extends Screen
}
}
}
if (detail.getNeededBy() != null) {
for (final ChangeInfo ci : detail.getNeededBy()) {
if ((ci.getStatus() == Change.Status.NEW) ||
(ci.getStatus() == Change.Status.SUBMITTED)) {
depsOpen = true;
}
}
if (detail.getNeededBy() != null) {
for (final ChangeInfo ci : detail.getNeededBy()) {
if ((ci.getStatus() == Change.Status.NEW) ||
(ci.getStatus() == Change.Status.SUBMITTED)) {
depsOpen = true;
}
}
}