opendev/gerrit
Code Issues Proposed changes

Remove StorageException from throws clauses

Browse Source 
Change-Id: I48a0169293ddf766fbbd924cb310f9b8dacc58cf
This commit is contained in:
Dave Borowitz
2019-01-15 19:16:44 -08:00
parent a4fe999a75
commit bd856a44ba
386 changed files with 1022 additions and 1607 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/com/google/gerrit/sshd/ChangeArgumentParser.java
View File

@@ -14,7 +14,6 @@
package com.google.gerrit.sshd;
import com.google.gerrit.exceptions.StorageException;
import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.reviewdb.client.Change;
@@ -55,13 +54,13 @@ public class ChangeArgumentParser {
}
public void addChange(String id, Map<Change.Id, ChangeResource> changes)
throws UnloggedFailure, StorageException, PermissionBackendException, IOException {
throws UnloggedFailure, PermissionBackendException, IOException {
addChange(id, changes, null);
}
public void addChange(
String id, Map<Change.Id, ChangeResource> changes, ProjectState projectState)
throws UnloggedFailure, StorageException, PermissionBackendException, IOException {
throws UnloggedFailure, PermissionBackendException, IOException {
addChange(id, changes, projectState, true);
}
@@ -70,7 +69,7 @@ public class ChangeArgumentParser {
Map<Change.Id, ChangeResource> changes,
ProjectState projectState,
boolean useIndex)
throws UnloggedFailure, StorageException, PermissionBackendException, IOException {
throws UnloggedFailure, PermissionBackendException, IOException {
List<ChangeNotes> matched = useIndex ? changeFinder.find(id) : changeFromNotesFactory(id);
List<ChangeNotes> toAdd = new ArrayList<>(changes.size());
boolean canMaintainServer;
@@ -116,8 +115,7 @@ public class ChangeArgumentParser {
changes.put(cId, changeResource);
}
private List<ChangeNotes> changeFromNotesFactory(String id)
throws StorageException, UnloggedFailure {
private List<ChangeNotes> changeFromNotesFactory(String id) throws UnloggedFailure {
return changeNotesFactory.create(parseId(id));
}