opendev/gerrit
Code Issues Proposed changes

Fix more rawtype warnings

Browse Source 
Change-Id: I50e401a7a604dde7bfad63639bdadb29c2b8a4a9
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2011-05-19 08:39:02 -07:00
parent b091b02391
commit bd8e5c1e8b
19 changed files with 36 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/CmdLineParser.java
View File

@@ -132,7 +132,7 @@ public class CmdLineParser {
super(bean);
}
@SuppressWarnings("unchecked")
@SuppressWarnings({"unchecked", "rawtypes"})
@Override
protected OptionHandler createOptionHandler(final OptionDef option,
final Setter setter) {
@@ -157,13 +157,11 @@ public class CmdLineParser {
return option.handler() != OptionHandler.class;
}
@SuppressWarnings("unchecked")
private boolean isEnum(final Setter setter) {
private <T> boolean isEnum(Setter<T> setter) {
return Enum.class.isAssignableFrom(setter.getType());
}
@SuppressWarnings("unchecked")
private boolean isPrimitive(final Setter setter) {
private <T> boolean isPrimitive(Setter<T> setter) {
return setter.getType().isPrimitive();
}
}

1
gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/OptionHandlerFactory.java
View File

@@ -20,6 +20,7 @@ import org.kohsuke.args4j.spi.Setter;
/** Creates an args4j OptionHandler through a Guice Injector. */
public interface OptionHandlerFactory<T> {
@SuppressWarnings("rawtypes")
OptionHandler create(org.kohsuke.args4j.CmdLineParser cmdLineParser,
OptionDef optionDef, Setter setter);
}