opendev/gerrit
Code Issues Proposed changes

remove the limit in the query of patch sets by revision.

Browse Source 
Currently there a limit of two for the results of query
based on revision. The reason to put this limit when the
query was written is unknown.
Since, there can be many changes that correspond to a
commit and all the changes should be provided to user,
this commit removes that limit.

Change-Id: I49401e37b70caa448176d6394bc0f9159ebe2fed
This commit is contained in:
Raviteja Sunkara 2013-04-26 21:59:16 +05:30
parent 76c7890be2
commit bd9cafde95
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/server/PatchSetAccess.java
View File

@ -30,10 +30,10 @@ public interface PatchSetAccess extends Access<PatchSet, PatchSet.Id> {
@Query("WHERE id.changeId = ? ORDER BY id.patchSetId") @Query("WHERE id.changeId = ? ORDER BY id.patchSetId")
ResultSet<PatchSet> byChange(Change.Id id) throws OrmException; ResultSet<PatchSet> byChange(Change.Id id) throws OrmException;
@Query("WHERE revision = ? LIMIT 2") @Query("WHERE revision = ?")
ResultSet<PatchSet> byRevision(RevId rev) throws OrmException; ResultSet<PatchSet> byRevision(RevId rev) throws OrmException;
@Query("WHERE revision >= ? AND revision <= ? LIMIT 2") @Query("WHERE revision >= ? AND revision <= ?")
ResultSet<PatchSet> byRevisionRange(RevId reva, RevId revb) ResultSet<PatchSet> byRevisionRange(RevId reva, RevId revb)
throws OrmException; throws OrmException;
} }