Merge "Treat NoSuchAlgorithmException consistently as IllegalStateException"

java/com/google/gerrit/httpd/auth/oauth/OAuthSession.java

@@ -237,7 +237,7 @@ class OAuthSession {
     try {
       return SecureRandom.getInstance("SHA1PRNG");
     } catch (NoSuchAlgorithmException e) {
-      throw new IllegalArgumentException("No SecureRandom available for GitHub authentication", e);
+      throw new IllegalStateException("No SecureRandom available for GitHub authentication", e);
     }
   }
 

java/com/google/gerrit/httpd/auth/openid/OAuthSessionOverOpenID.java

@@ -222,7 +222,7 @@ class OAuthSessionOverOpenID {
     try {
       return SecureRandom.getInstance("SHA1PRNG");
     } catch (NoSuchAlgorithmException e) {
-      throw new IllegalArgumentException("No SecureRandom available for GitHub authentication", e);
+      throw new IllegalStateException("No SecureRandom available for GitHub authentication", e);
     }
   }
 

java/com/google/gerrit/server/mail/send/FromAddressGeneratorProvider.java

@@ -234,7 +234,7 @@ public class FromAddressGeneratorProvider implements Provider<FromAddressGenerat
       byte[] bytes = hash.digest(data.getBytes(UTF_8));
       return BaseEncoding.base64Url().encode(bytes);
     } catch (NoSuchAlgorithmException e) {
-      throw new RuntimeException("No MD5 available", e);
+      throw new IllegalStateException("No MD5 available", e);
     }
   }
 }

java/com/google/gerrit/server/restapi/account/PutHttpPassword.java

@@ -68,7 +68,7 @@ public class PutHttpPassword implements RestModifyView<AccountResource, HttpPass
     try {
       rng = SecureRandom.getInstance("SHA1PRNG");
     } catch (NoSuchAlgorithmException e) {
-      throw new RuntimeException("Cannot create RNG for password generator", e);
+      throw new IllegalStateException("Cannot create RNG for password generator", e);
     }
   }
 

java/com/google/gerrit/server/util/CommitMessageUtil.java

@@ -34,7 +34,7 @@ public class CommitMessageUtil {
     try {
       rng = SecureRandom.getInstance("SHA1PRNG");
     } catch (NoSuchAlgorithmException e) {
-      throw new RuntimeException("Cannot create RNG for Change-Id generator", e);
+      throw new IllegalStateException("Cannot create RNG for Change-Id generator", e);
     }
   }