opendev/gerrit
Code Issues Proposed changes

Remove unused commit field from SyncProjectRequest

Browse Source 
Gerrit hasn't required the commit field per-branch in a long time,
since before the code tree was open sourced.  It was an accident
that we didn't remove this sooner, as it only complicates the
project initialization process.

Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2008-10-22 16:26:19 -07:00
parent baeb3d8f1b
commit be63d10068
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
mgrapp/src/com/google/codereview/manager/ProjectSync.java
View File

@@ -113,7 +113,6 @@ public class ProjectSync {
private BranchSync toBranch(final Ref r, final RevCommit c) { private BranchSync toBranch(final Ref r, final RevCommit c) {
final BranchSync.Builder bs = BranchSync.newBuilder(); final BranchSync.Builder bs = BranchSync.newBuilder();
bs.setBranchName(r.getName()); bs.setBranchName(r.getName());
bs.setCommit(GitMetaUtil.toGitCommit(c));
return bs.build(); return bs.build();
} }

4
proto/internal/sync_project.proto
View File

@@ -15,11 +15,9 @@
package codereview.internal; package codereview.internal;
option java_package = "com.google.codereview.internal"; option java_package = "com.google.codereview.internal";
import "git_meta.proto";
message BranchSync { message BranchSync {
required string branch_name = 1; required string branch_name = 1;
required GitCommit commit = 2; // field 2 used to be "commit"
} }
message SyncProjectRequest { message SyncProjectRequest {