opendev/gerrit
Code Issues Proposed changes

Merge "IndexConfig: Remove checkTypeLimit to restore supporting any type"

Browse Source
This commit is contained in:
Patrick Hiesel
2019-10-01 12:13:01 +00:00
committed by Gerrit Code Review
parent 29033ef5b4 1940faf163
commit be964075a3
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/com/google/gerrit/index/IndexConfig.java
View File

@@ -91,7 +91,6 @@ public abstract class IndexConfig {
checkLimit(cfg.maxLimit(), "maxLimit"); checkLimit(cfg.maxLimit(), "maxLimit");
checkLimit(cfg.maxPages(), "maxPages"); checkLimit(cfg.maxPages(), "maxPages");
checkLimit(cfg.maxTerms(), "maxTerms"); checkLimit(cfg.maxTerms(), "maxTerms");
checkTypeLimit(cfg);
return cfg; return cfg;
} }
} }
@@ -100,12 +99,6 @@ public abstract class IndexConfig {
checkArgument(limit > 0, "%s must be positive: %s", name, limit); checkArgument(limit > 0, "%s must be positive: %s", name, limit);
} }
private static void checkTypeLimit(IndexConfig cfg) {
String limit = cfg.type();
boolean known = IndexType.getKnownTypes().asList().contains(limit);
checkArgument(known, "type must be known: %s", limit);
}
/** /**
* @return maximum limit supported by the underlying index, or limited for performance reasons. * @return maximum limit supported by the underlying index, or limited for performance reasons.
*/ */
@@ -123,7 +116,7 @@ public abstract class IndexConfig {
*/ */
public abstract int maxTerms(); public abstract int maxTerms();
/** @return index type, limited to be either one of the known types. */ /** @return index type. */
public abstract String type(); public abstract String type();
/** /**