From bf9d9ed9876d8e166f26c76d4e230a673b90e9f8 Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Tue, 31 May 2011 09:52:38 -0700 Subject: [PATCH] ExportReviewNotes: Default to 2 threads Not all systems have enough database connections in the connection pool to support 2 threads per CPU. Exporting lots of changes doesn't take that long, so 2 threads is acceptable. Change-Id: I69bbade7f67023689ca54665833bc764d2d5503d Signed-off-by: Shawn O. Pearce --- Documentation/pgm-ExportReviewNotes.txt | 3 +-- .../src/main/java/com/google/gerrit/pgm/ExportReviewNotes.java | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/pgm-ExportReviewNotes.txt b/Documentation/pgm-ExportReviewNotes.txt index b43989fa57..602c245e87 100644 --- a/Documentation/pgm-ExportReviewNotes.txt +++ b/Documentation/pgm-ExportReviewNotes.txt @@ -29,8 +29,7 @@ OPTIONS configuration data, supporting libaries and log files. \--threads:: - Number of threads to perform the scan work with. Defaults to - twice the number of CPUs available. + Number of threads to perform the scan work with. Default: 2. CONTEXT ------- diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/ExportReviewNotes.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/ExportReviewNotes.java index b8e4160c17..71512f26ed 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/ExportReviewNotes.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/ExportReviewNotes.java @@ -63,7 +63,7 @@ import java.util.Map.Entry; /** Export review notes for all submitted changes in all projects. */ public class ExportReviewNotes extends SiteProgram { @Option(name = "--threads", usage = "Number of concurrent threads to run") - private int threads = 2 * Runtime.getRuntime().availableProcessors(); + private int threads = 2; private final LifecycleManager manager = new LifecycleManager(); private final TextProgressMonitor textMonitor = new TextProgressMonitor();