opendev/gerrit
Code Issues Proposed changes

Merge "Fix message if pushing tag is rejected because tagger is somebody else"

Browse Source
This commit is contained in:
Shawn Pearce 2012-09-16 12:20:26 -07:00 committed by gerrit code review
commit bfc291252b
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Documentation/error-prohibited-by-gerrit.txt
View File

@ -19,6 +19,9 @@ In particular this error occurs:
access right on 'refs/tags/*'
4. if you push a lightweight tag without the access right link:access-control.html#category_create['Create
Reference'] for the reference name 'refs/tags/*'
5. if you push a tag with somebody else as tagger and you don't have the
link:access-control.html#category_forge_committer['Forge Committer']
access right for the reference name 'refs/tags/*'
For new users it often happens that they accidentally try to bypass
code review. The push then fails with the error message 'prohibited

2
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@ -837,7 +837,7 @@ public class ReceiveCommits {
batch.addCommand(cmd);
} else {
errors.put(Error.CREATE, ctl.getRefName());
reject(cmd, "can not create new references");
reject(cmd);
}
}