PostReview: Disallow modifying other people's drafts

Having permission to review on behalf of another user should not give
you permission to publish or delete their draft comments, as they were
not visible to you. And it's just not very nice.

Change-Id: I76247a055d43a6d68d16cba871f262a07063d9af
This commit is contained in:
Dave Borowitz
2016-10-05 16:19:21 -04:00
parent 5c570f61ef
commit c064054d4f
4 changed files with 20 additions and 14 deletions

View File

@@ -49,8 +49,11 @@ public class ReviewInput {
/**
* How to process draft comments already in the database that were not also
* described in this input request.
* <p>
* Defaults to DELETE, unless {@link #onBehalfOf} is set, in which case it
* defaults to KEEP and any other value is disallowed.
*/
public DraftHandling drafts = DraftHandling.DELETE;
public DraftHandling drafts;
/** Who to send email notifications to after review is stored. */
public NotifyHandling notify = NotifyHandling.ALL;