opendev/gerrit
Code Issues Proposed changes

Convert PatchSetApproval.Key to AutoValue

Browse Source 
While we're in there, rename the underlying field from categoryId to
labelId, including renaming the proto field. This is cleanup following
from I5df6f0c5. At that time, we opted to leave the name the same
because Megastore had problems with renaming proto fields and hence we
couldn't easily rename @Column fields. Now that ReviewDb (including the
Megastore implementation) is gone, this argument no longer applies.

See I6982fb24 for context.

Change-Id: I011e0bfeb74345a20b5eb0bb97ce61de7cb12bd0
This commit is contained in:
Dave Borowitz
2019-04-17 12:53:07 -07:00
parent 19101e65cf
commit c144e78d78
16 changed files with 55 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
proto/entities.proto
View File

@@ -120,7 +120,7 @@ message LabelId {
message PatchSetApproval_Key {
required PatchSet_Id patch_set_id = 1;
required Account_Id account_id = 2;
required LabelId category_id = 3;
required LabelId label_id = 3;
}
// Serialized form of com.google.gerrit.reviewdb.client.PatchSetApproval.