opendev/gerrit
Code Issues Proposed changes

CreateBranch: Test that branches cannot be created with invalid names

Browse Source 
This increases the test coverage of the CreateBranch REST endpoint.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I86e46cf34e49172be2fb15e8970c5dca5aa2dd1f
This commit is contained in:
Edwin Kempin
2020-03-25 10:54:34 +01:00
parent b4ab1d3a6a
commit c1571fb30a
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javatests/com/google/gerrit/acceptance/rest/project/CreateBranchIT.java
View File

@@ -336,6 +336,14 @@ public class CreateBranchIT extends AbstractDaemonTest {
"not allowed to create branches under \"" + MagicBranch.NEW_CHANGE + "\""); "not allowed to create branches under \"" + MagicBranch.NEW_CHANGE + "\"");
} }
@Test
public void cannotCreateBranchWithInvalidName() throws Exception {
assertCreateFails(
BranchNameKey.create(project, RefNames.REFS_HEADS),
BadRequestException.class,
"invalid branch name \"" + RefNames.REFS_HEADS + "\"");
}
@Test @Test
public void createBranchLeadingSlashesAreRemoved() throws Exception { public void createBranchLeadingSlashesAreRemoved() throws Exception {
BranchNameKey expectedNameKey = BranchNameKey.create(project, "test"); BranchNameKey expectedNameKey = BranchNameKey.create(project, "test");