From 7807549402248c86210563658b6f5bcff3f6a973 Mon Sep 17 00:00:00 2001 From: Paladox none Date: Sun, 22 Oct 2017 15:47:23 +0000 Subject: [PATCH 1/2] Remove duplicate SHA1 variable in js.bzl Change-Id: Id9f8e724fdf62ea482a240561a78e9034248419d --- tools/bzl/js.bzl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/bzl/js.bzl b/tools/bzl/js.bzl index d110f3ec1e..77ac71b73b 100644 --- a/tools/bzl/js.bzl +++ b/tools/bzl/js.bzl @@ -21,7 +21,7 @@ def _npm_binary_impl(ctx): """rule to download a NPM archive.""" name = ctx.name version= NPM_VERSIONS[name] - sha1 = NPM_VERSIONS[name] + sha1 = NPM_SHA1S[name] dir = '%s-%s' % (name, version) filename = '%s.tgz' % dir @@ -38,7 +38,6 @@ def _npm_binary_impl(ctx): python = ctx.which("python") script = ctx.path(ctx.attr._download_script) - sha1 = NPM_SHA1S[name] args = [python, script, "-o", dest, "-u", url, "-v", sha1] out = ctx.execute(args) if out.return_code: From 4142f2d949aee711b778f281ca1476ac18fa4389 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Mon, 23 Oct 2017 16:49:38 +0900 Subject: [PATCH 2/2] Upgrade GWT to version 2.8.2 This version includes a fix for incorrect getAbsoluteLeft/Top values in Chrome 61 and later [1], plus various other bugfixes. See the release notes [2] for full details. See also the release notes for 2.8.1 [3] which is also included in this upgrade. [1] https://github.com/gwtproject/gwt/issues/9542 [2] http://www.gwtproject.org/release-notes.html#Release_Notes_2_8_2 [3] http://www.gwtproject.org/release-notes.html#Release_Notes_2_8_1 Bug: Issue 7519 Change-Id: If6da895e1349336b8853767a537ed4a09c2773f5 --- WORKSPACE | 6 +++--- lib/BUILD | 1 + tools/bzl/gwt.bzl | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index b2c7006358..dd1fa7076b 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -100,18 +100,18 @@ maven_jar( sha1 = "5d9e2e895e3111622720157d0aa540066d5fce3a", ) -GWT_VERS = "2.8.0" +GWT_VERS = "2.8.2" maven_jar( name = "user", artifact = "com.google.gwt:gwt-user:" + GWT_VERS, - sha1 = "518579870499e15531f454f35dca0772d7fa31f7", + sha1 = "a2b9be2c996a658c4e009ba652a9c6a81c88a797", ) maven_jar( name = "dev", artifact = "com.google.gwt:gwt-dev:" + GWT_VERS, - sha1 = "f160a61272c5ebe805cd2d3d3256ed3ecf14893f", + sha1 = "7a87e060bbf129386b7ae772459fb9f87297c332", ) maven_jar( diff --git a/lib/BUILD b/lib/BUILD index c2148bfc6d..91334cb83d 100644 --- a/lib/BUILD +++ b/lib/BUILD @@ -176,6 +176,7 @@ java_library( java_library( name = "jsr305", data = ["//lib:LICENSE-Apache2.0"], + visibility = ["//visibility:public"], exports = ["@jsr305//jar"], ) diff --git a/tools/bzl/gwt.bzl b/tools/bzl/gwt.bzl index cfd0c82017..079989849c 100644 --- a/tools/bzl/gwt.bzl +++ b/tools/bzl/gwt.bzl @@ -66,6 +66,7 @@ GWT_PLUGIN_DEPS = [ ] GWT_TRANSITIVE_DEPS = [ + "//lib:jsr305", "//lib/gwt:ant", "//lib/gwt:colt", "//lib/gwt:javax-validation",