diff --git a/java/com/google/gerrit/server/git/GarbageCollection.java b/java/com/google/gerrit/server/git/GarbageCollection.java index 3bf89c7d78..997907e2a1 100644 --- a/java/com/google/gerrit/server/git/GarbageCollection.java +++ b/java/com/google/gerrit/server/git/GarbageCollection.java @@ -41,9 +41,6 @@ import org.slf4j.LoggerFactory; public class GarbageCollection { private static final Logger log = LoggerFactory.getLogger(GarbageCollection.class); - public static final String LOG_NAME = "gc_log"; - private static final Logger gcLog = LoggerFactory.getLogger(LOG_NAME); - private final GitRepositoryManager repoManager; private final GarbageCollectionQueue gcQueue; private final GcConfig gcConfig; @@ -142,7 +139,7 @@ public class GarbageCollection { } b.append(s); } - gcLog.info(b.toString()); + log.info(b.toString()); } private static void logGcConfiguration( @@ -182,7 +179,6 @@ public class GarbageCollection { print(writer, "failed.\n\n"); StringBuilder b = new StringBuilder(); b.append("[").append(projectName.get()).append("]"); - gcLog.error(b.toString(), e); log.error(b.toString(), e); } diff --git a/java/com/google/gerrit/server/git/GarbageCollectionLogFile.java b/java/com/google/gerrit/server/git/GarbageCollectionLogFile.java index e03ef678cc..8796fdf839 100644 --- a/java/com/google/gerrit/server/git/GarbageCollectionLogFile.java +++ b/java/com/google/gerrit/server/git/GarbageCollectionLogFile.java @@ -26,6 +26,8 @@ import org.apache.log4j.PatternLayout; import org.eclipse.jgit.lib.Config; public class GarbageCollectionLogFile implements LifecycleListener { + private static final String LOG_NAME = "gc_log"; + @Inject public GarbageCollectionLogFile(SitePaths sitePaths, @GerritServerConfig Config config) { if (SystemLog.shouldConfigure()) { @@ -38,15 +40,20 @@ public class GarbageCollectionLogFile implements LifecycleListener { @Override public void stop() { - LogManager.getLogger(GarbageCollection.LOG_NAME).removeAllAppenders(); + LogManager.getLogger(GarbageCollection.class).removeAllAppenders(); + LogManager.getLogger(GarbageCollectionRunner.class).removeAllAppenders(); } private static void initLogSystem(Path logdir, boolean rotate) { - Logger gcLogger = LogManager.getLogger(GarbageCollection.LOG_NAME); + initGcLogger(logdir, rotate, LogManager.getLogger(GarbageCollection.class)); + initGcLogger(logdir, rotate, LogManager.getLogger(GarbageCollectionRunner.class)); + } + + private static void initGcLogger(Path logdir, boolean rotate, Logger gcLogger) { gcLogger.removeAllAppenders(); gcLogger.addAppender( SystemLog.createAppender( - logdir, GarbageCollection.LOG_NAME, new PatternLayout("[%d] %-5p %x: %m%n"), rotate)); + logdir, LOG_NAME, new PatternLayout("[%d] %-5p %x: %m%n"), rotate)); gcLogger.setAdditivity(false); } } diff --git a/java/com/google/gerrit/server/git/GarbageCollectionRunner.java b/java/com/google/gerrit/server/git/GarbageCollectionRunner.java index e4316c509b..054e56afd6 100644 --- a/java/com/google/gerrit/server/git/GarbageCollectionRunner.java +++ b/java/com/google/gerrit/server/git/GarbageCollectionRunner.java @@ -24,7 +24,7 @@ import org.slf4j.LoggerFactory; /** Runnable to enable scheduling gc to run periodically */ public class GarbageCollectionRunner implements Runnable { - private static final Logger gcLog = LoggerFactory.getLogger(GarbageCollection.LOG_NAME); + private static final Logger log = LoggerFactory.getLogger(GarbageCollectionRunner.class); static class Lifecycle implements LifecycleListener { private final WorkQueue queue; @@ -61,7 +61,7 @@ public class GarbageCollectionRunner implements Runnable { @Override public void run() { - gcLog.info("Triggering gc on all repositories"); + log.info("Triggering gc on all repositories"); garbageCollectionFactory.create().run(Lists.newArrayList(projectCache.all())); }