opendev/gerrit
Code Issues Proposed changes

Remove changeView from the plugin API

Browse Source 
The plugin.changeView references the non-existing GrChangeViewApi class.

Change-Id: I505f7d8fc7a75a36248d41639be5315d7a358dc6
This commit is contained in:
Dmitrii Filippov
2020-04-06 16:26:42 +02:00
parent b3439d54d0
commit c1afe41564
3 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/pg-plugin-dev.txt
View File

@@ -211,11 +211,6 @@ to be used by plugin authors.
Note: TODO Note: TODO
=== changeView
`plugin.changeView()`
Note: TODO
=== delete === delete
`plugin.delete(url, opt_callback)` `plugin.delete(url, opt_callback)`

1
polygerrit-ui/app/.eslintrc.js
View File

@@ -166,7 +166,6 @@ module.exports = {
// Instead export variables from modules // Instead export variables from modules
// TODO(dmfilippov): Remove global variables from polygerrit // TODO(dmfilippov): Remove global variables from polygerrit
"Gerrit": "readonly", "Gerrit": "readonly",
"GrChangeViewApi": "readonly",
"GrEventHelper": "readonly", "GrEventHelper": "readonly",
"GrPluginActionContext": "readonly", "GrPluginActionContext": "readonly",
"GrPluginRestApi": "readonly", "GrPluginRestApi": "readonly",

4
polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js
View File

@@ -206,10 +206,6 @@ import {GrChangeMetadataApi} from '../../plugins/gr-change-metadata-api/gr-chang
return new GrChangeReplyInterface(this); return new GrChangeReplyInterface(this);
}; };
Plugin.prototype.changeView = function() {
return new GrChangeViewApi(this);
};
Plugin.prototype.theme = function() { Plugin.prototype.theme = function() {
return new GrThemeApi(this); return new GrThemeApi(this);
}; };