opendev/gerrit
Code Issues Proposed changes

Fix subject for "Updated Changes" lines on push

Browse Source 
When a change was updated it showed the subject from the previous
patch set and not as expected the subject from the new current patch
set.

Bug: Issue 4055
Change-Id: I33d1912cccea795fc003a07bc88800c536c301da
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2016-04-13 09:11:14 +02:00
parent 697bc32e50
commit c33e32e0ba
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@@ -696,7 +696,8 @@ public class ReceiveCommits {
addMessage(""); addMessage("");
addMessage("New Changes:"); addMessage("New Changes:");
for (CreateRequest c : created) { for (CreateRequest c : created) {
addMessage(formatChangeUrl(canonicalWebUrl, c.change, false)); addMessage(formatChangeUrl(canonicalWebUrl, c.change,
c.change.getSubject(), false));
} }
addMessage(""); addMessage("");
} }
@@ -721,20 +722,21 @@ public class ReceiveCommits {
addMessage("Updated Changes:"); addMessage("Updated Changes:");
boolean edit = magicBranch != null && magicBranch.edit; boolean edit = magicBranch != null && magicBranch.edit;
for (ReplaceRequest u : updated) { for (ReplaceRequest u : updated) {
addMessage(formatChangeUrl(canonicalWebUrl, u.change, edit)); addMessage(formatChangeUrl(canonicalWebUrl, u.change,
u.info.getSubject(), edit));
} }
addMessage(""); addMessage("");
} }
} }
private static String formatChangeUrl(String url, Change change, private static String formatChangeUrl(String url, Change change,
boolean edit) { String subject, boolean edit) {
StringBuilder m = new StringBuilder() StringBuilder m = new StringBuilder()
.append(" ") .append(" ")
.append(url) .append(url)
.append(change.getChangeId()) .append(change.getChangeId())
.append(" ") .append(" ")
.append(ChangeUtil.cropSubject(change.getSubject())); .append(ChangeUtil.cropSubject(subject));
if (change.getStatus() == Change.Status.DRAFT) { if (change.getStatus() == Change.Status.DRAFT) {
m.append(" [DRAFT]"); m.append(" [DRAFT]");
} }