opendev/gerrit
Code Issues Proposed changes

SideBySide2: Add user preference to hide top menu

Browse Source 
The top menu occupies a lot of space. I personally prefer the
version of SideBySide2 that hides the top menu when CM3 has scrolled
down some number of lines. Allow users to hide the top menu as a
preference, gaining back some screen space for code.

Change-Id: Ib30e8875fcc4b87662a5c12fa0bf3cc791d02c95
This commit is contained in:
Shawn Pearce
2013-12-04 14:29:30 -08:00
parent 57f8b1eba9
commit c344e89a2b
11 changed files with 82 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/ScrollSynchronizer.java
View File

@@ -14,7 +14,6 @@
package com.google.gerrit.client.diff;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.diff.LineMapper.LineOnOtherInfo;
import com.google.gwt.user.client.Timer;
@@ -38,10 +37,10 @@ class ScrollSynchronizer {
}
private void updateScreenHeader(ScrollInfo si) {
if (si.getTop() == 0 && !Gerrit.isHeaderVisible()) {
if (si.getTop() == 0 && !diffTable.isHeaderVisible()) {
diffTable.setHeaderVisible(true);
} else if (si.getTop() > 0.5 * si.getClientHeight()
&& Gerrit.isHeaderVisible()) {
&& diffTable.isHeaderVisible()) {
diffTable.setHeaderVisible(false);
}
}