opendev/gerrit
Code Issues Proposed changes

Use more portable printf instead of echo -n

Browse Source 
Mac OS X's /bin/sh does not support echo -n.  Instead use the much
more widely supported printf with a format string of just %s.

Change-Id: I77ac99e7fff7432e3eaf663284e8b2950239ff88
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-12-11 04:44:08 -08:00
parent 53f5e992b4
commit c3599d60ba
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-war/src/main/webapp/WEB-INF/extra/bin/gerrit.sh
View File

@@ -349,7 +349,7 @@ fi
################################################## ##################################################
case "$ACTION" in case "$ACTION" in
start) start)
echo -n "Starting Gerrit Code Review: " printf '%s' "Starting Gerrit Code Review: "
if test 1 = "$NO_START" ; then if test 1 = "$NO_START" ; then
echo "Not starting gerrit - NO_START=1 in /etc/default/gerrit" echo "Not starting gerrit - NO_START=1 in /etc/default/gerrit"
@@ -401,7 +401,7 @@ case "$ACTION" in
;; ;;
stop) stop)
echo -n "Stopping Gerrit Code Review: " printf '%s' "Stopping Gerrit Code Review: "
if test 1 = "$START_STOP_DAEMON" && type start-stop-daemon >/dev/null 2>&1 if test 1 = "$START_STOP_DAEMON" && type start-stop-daemon >/dev/null 2>&1
then then