From c3f35e61b8e42fb49a0fe467182037f750556af6 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 3 Jun 2015 14:49:16 +0900 Subject: [PATCH] RequestUtilTest: Convert to use Google Truth Change-Id: Ib6d4cbded2ce2c9d731ff9621ed69dc7c136265d --- gerrit-util-http/BUCK | 1 + .../gerrit/util/http/RequestUtilTest.java | 38 +++++++++---------- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/gerrit-util-http/BUCK b/gerrit-util-http/BUCK index 7041c0aaf8..e770f60aa5 100644 --- a/gerrit-util-http/BUCK +++ b/gerrit-util-http/BUCK @@ -12,6 +12,7 @@ java_test( ':http', '//lib:junit', '//lib:servlet-api-3_1', + '//lib:truth', '//lib/easymock:easymock', ], source_under_test = [':http'], diff --git a/gerrit-util-http/src/test/java/com/google/gerrit/util/http/RequestUtilTest.java b/gerrit-util-http/src/test/java/com/google/gerrit/util/http/RequestUtilTest.java index cfa0111ac2..42fcb16584 100644 --- a/gerrit-util-http/src/test/java/com/google/gerrit/util/http/RequestUtilTest.java +++ b/gerrit-util-http/src/test/java/com/google/gerrit/util/http/RequestUtilTest.java @@ -14,11 +14,11 @@ package com.google.gerrit.util.http; +import static com.google.common.truth.Truth.assertThat; import static org.easymock.EasyMock.createMock; import static org.easymock.EasyMock.expect; import static org.easymock.EasyMock.replay; import static org.easymock.EasyMock.verify; -import static org.junit.Assert.assertEquals; import org.junit.After; import org.junit.Before; @@ -47,36 +47,36 @@ public class RequestUtilTest { @Test public void emptyContextPath() { - assertEquals("/foo/bar", RequestUtil.getEncodedPathInfo( - mockRequest("/s/foo/bar", "", "/s"))); - assertEquals("/foo%2Fbar", RequestUtil.getEncodedPathInfo( - mockRequest("/s/foo%2Fbar", "", "/s"))); + assertThat(RequestUtil.getEncodedPathInfo( + mockRequest("/s/foo/bar", "", "/s"))).isEqualTo("/foo/bar"); + assertThat(RequestUtil.getEncodedPathInfo( + mockRequest("/s/foo%2Fbar", "", "/s"))).isEqualTo("/foo%2Fbar"); } @Test public void emptyServletPath() { - assertEquals("/foo/bar", RequestUtil.getEncodedPathInfo( - mockRequest("/c/foo/bar", "/c", ""))); - assertEquals("/foo%2Fbar", RequestUtil.getEncodedPathInfo( - mockRequest("/c/foo%2Fbar", "/c", ""))); + assertThat(RequestUtil.getEncodedPathInfo( + mockRequest("/c/foo/bar", "", "/c"))).isEqualTo("/foo/bar"); + assertThat(RequestUtil.getEncodedPathInfo( + mockRequest("/c/foo%2Fbar", "", "/c"))).isEqualTo("/foo%2Fbar"); } @Test public void trailingSlashes() { - assertEquals("/foo/bar/", RequestUtil.getEncodedPathInfo( - mockRequest("/c/s/foo/bar/", "/c", "/s"))); - assertEquals("/foo/bar/", RequestUtil.getEncodedPathInfo( - mockRequest("/c/s/foo/bar///", "/c", "/s"))); - assertEquals("/foo%2Fbar/", RequestUtil.getEncodedPathInfo( - mockRequest("/c/s/foo%2Fbar/", "/c", "/s"))); - assertEquals("/foo%2Fbar/", RequestUtil.getEncodedPathInfo( - mockRequest("/c/s/foo%2Fbar///", "/c", "/s"))); + assertThat(RequestUtil.getEncodedPathInfo( + mockRequest("/c/s/foo/bar/", "/c", "/s"))).isEqualTo("/foo/bar/"); + assertThat(RequestUtil.getEncodedPathInfo( + mockRequest("/c/s/foo/bar///", "/c", "/s"))).isEqualTo("/foo/bar/"); + assertThat(RequestUtil.getEncodedPathInfo( + mockRequest("/c/s/foo%2Fbar/", "/c", "/s"))).isEqualTo("/foo%2Fbar/"); + assertThat(RequestUtil.getEncodedPathInfo( + mockRequest("/c/s/foo%2Fbar///", "/c", "/s"))).isEqualTo("/foo%2Fbar/"); } @Test public void servletPathMatchesRequestPath() { - assertEquals(null, RequestUtil.getEncodedPathInfo( - mockRequest("/c/s", "/c", "/s"))); + assertThat(RequestUtil.getEncodedPathInfo( + mockRequest("/c/s", "/c", "/s"))).isNull(); } private HttpServletRequest mockRequest(String uri, String contextPath, String servletPath) {