opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-2.14'

Browse Source 
* stable-2.14:
  ChangeApiImpl: Don't catch bare Exception when getting past assignees
  ChangeApiImpl: Don't catch RestApiException when editing hashtag

Change-Id: I788b52eefd6afb30e7d9691a92eccd09c247b5af
This commit is contained in:
David Pursehouse
2017-03-29 21:27:08 +09:00
parent 7aab0e87a9 811b72685b
commit c40de715e8
2 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/api/changes/ChangeApiImpl.java
View File

@@ -475,7 +475,7 @@ class ChangeApiImpl implements ChangeApi {
public void setHashtags(HashtagsInput input) throws RestApiException {
try {
postHashtags.apply(change, input);
} catch (RestApiException | UpdateException e) {
} catch (UpdateException e) {
throw new RestApiException("Cannot post hashtags", e);
}
}
@@ -512,7 +512,7 @@ class ChangeApiImpl implements ChangeApi {
public List<AccountInfo> getPastAssignees() throws RestApiException {
try {
return getPastAssignees.apply(change).value();
} catch (Exception e) {
} catch (OrmException e) {
throw new RestApiException("Cannot get past assignees", e);
}
}