opendev/gerrit
Code Issues Proposed changes

Improve error handling in 'gr-change-list-view'

Browse Source 
- hide link 'Next' when an error occurs
- hide links 'Next' / 'Prev' initially
  (and thus property '_changes' is undefined)
- remove unused code

Change-Id: Ib6f77232481988b81aad8b996bfc9c9432c4d826
This commit is contained in:
Urs Wolfer
2016-06-04 16:39:41 +02:00
parent bd98fad7aa
commit c41ae08d17
2 changed files with 7 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.html
View File

@@ -49,17 +49,17 @@ limitations under the License.
}
}
</style>
<div class="loading" hidden$="[[!_loading]]">Loading...</div>
<div hidden$="[[_loading]]">
<div class="loading" hidden$="[[!_loading]]" hidden>Loading...</div>
<div hidden$="[[_loading]]" hidden>
<gr-change-list
changes="{{_changes}}"
selected-index="{{viewState.selectedChangeIndex}}"
show-star="[[loggedIn]]"></gr-change-list>
<nav>
<a href$="[[_computeNavLink(_query, _offset, -1, _changesPerPage)]]"
hidden$="[[_hidePrevArrow(_offset)]]">&larr; Prev</a>
hidden$="[[_hidePrevArrow(_offset)]]" hidden>&larr; Prev</a>
<a href$="[[_computeNavLink(_query, _offset, 1, _changesPerPage)]]"
hidden$="[[_hideNextArrow(_changes.length, _changesPerPage)]]">
hidden$="[[_hideNextArrow(_loading, _changesPerPage)]]" hidden>
Next &rarr;</a>
</nav>
</div>

14
polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js
View File

@@ -123,20 +123,12 @@
return href;
},
_computeErrorHidden: function(loading, lastError) {
return loading || lastError == null;
},
_computeListHidden: function(loading, lastError) {
return loading || lastError != null;
},
_hidePrevArrow: function(offset) {
return offset == 0;
return offset === 0;
},
_hideNextArrow: function(changesLen, changesPerPage) {
return changesLen < changesPerPage;
_hideNextArrow: function(loading, changesPerPage) {
return loading || !this._changes || this._changes.length < changesPerPage;
},
});
})();