Merge "Simplify change email styles"

This commit is contained in:
Dave Borowitz
2016-10-31 18:35:36 +00:00
committed by Gerrit Code Review
10 changed files with 14 additions and 30 deletions

View File

@@ -24,8 +24,7 @@
*/ */
{template .AbandonedHtml autoescape="strict" kind="html"} {template .AbandonedHtml autoescape="strict" kind="html"}
<p> <p>
<strong>{$fromName}</strong> abandoned{sp} {$fromName} abandoned <strong>{$change.subject}</strong>.
<strong>{$change.subject}</strong>.
</p> </p>
{if $email.changeUrl} {if $email.changeUrl}

View File

@@ -44,8 +44,7 @@
{/let} {/let}
<p> <p>
<strong>{$fromName}</strong> posted comments on{sp} {$fromName} posted comments on <strong>{$change.subject}</strong>.
<strong>{$change.subject}</strong>.
</p> </p>
{if $email.changeUrl} {if $email.changeUrl}
@@ -62,7 +61,7 @@
{foreach $group in $commentFiles} {foreach $group in $commentFiles}
<li> <li>
<p> <p>
<strong><a href="{$group.link}">{$group.title}:</a></strong> <a href="{$group.link}">{$group.title}:</a>
</p> </p>
<ul style="{$ulStyle}"> <ul style="{$ulStyle}">

View File

@@ -24,10 +24,10 @@
*/ */
{template .DeleteReviewerHtml autoescape="strict" kind="html"} {template .DeleteReviewerHtml autoescape="strict" kind="html"}
<p> <p>
<strong>{$fromName}</strong> removed{sp} {$fromName} removed{sp}
{foreach $reviewerName in $email.reviewerNames} {foreach $reviewerName in $email.reviewerNames}
{if not isFirst($reviewerName)},{sp}{/if} {if not isFirst($reviewerName)},{sp}{/if}
<strong>{$reviewerName}</strong> {$reviewerName}
{/foreach}{sp} {/foreach}{sp}
from <strong>{$change.subject}</strong>. from <strong>{$change.subject}</strong>.
</p> </p>

View File

@@ -24,8 +24,7 @@
*/ */
{template .DeleteVoteHtml autoescape="strict" kind="html"} {template .DeleteVoteHtml autoescape="strict" kind="html"}
<p> <p>
<strong>{$fromName}</strong> removed a vote from{sp} {$fromName} removed a vote from <strong>{$change.subject}</strong>.
<strong>{$change.subject}</strong>.
</p> </p>
{if $email.changeUrl} {if $email.changeUrl}

View File

@@ -23,7 +23,7 @@
*/ */
{template .MergedHtml autoescape="strict" kind="html"} {template .MergedHtml autoescape="strict" kind="html"}
<p> <p>
<strong>{$fromName}</strong> merged <strong>{$change.subject}</strong>. {$fromName} merged <strong>{$change.subject}</strong>.
</p> </p>
{if $email.changeUrl} {if $email.changeUrl}

View File

@@ -26,17 +26,16 @@
{template .NewChangeHtml autoescape="strict" kind="html"} {template .NewChangeHtml autoescape="strict" kind="html"}
<p> <p>
{if $email.reviewerNames} {if $email.reviewerNames}
<strong>{$fromName}</strong> would like{sp} {$fromName} would like{sp}
{foreach $reviewerName in $email.reviewerNames} {foreach $reviewerName in $email.reviewerNames}
{if not isFirst($reviewerName)} {if not isFirst($reviewerName)}
{if isLast($reviewerName)}{sp}and{else},{/if}{sp} {if isLast($reviewerName)}{sp}and{else},{/if}{sp}
{/if} {/if}
<strong>{$reviewerName}</strong> {$reviewerName}
{/foreach}{sp} {/foreach}{sp}
to review <strong>{$change.subject}</strong>. to review <strong>{$change.subject}</strong>.
{else} {else}
<strong>{$fromName}</strong> uploaded{sp} {$fromName} uploaded <strong>{$change.subject}</strong> for review.
<strong>{$change.subject}</strong> for review.
{/if} {/if}
</p> </p>

View File

@@ -25,16 +25,7 @@
* @param email * @param email
*/ */
{template .ViewChangeButton private="true" autoescape="strict" kind="html"} {template .ViewChangeButton private="true" autoescape="strict" kind="html"}
{let $visitButtonStyle kind="css"} <a href="{$email.changeUrl}">View Change</a>
background: #4d90fe;
border: 1px solid #3079ed;
border-radius: 4px;
color: #fff;
display: inline-block;
margin-right: 8px;
padding: 6px 12px;
{/let}
<a style="{$visitButtonStyle}" href="{$email.changeUrl}">View Change</a>
{/template} {/template}
/** /**

View File

@@ -25,8 +25,7 @@
*/ */
{template .ReplacePatchSetHtml autoescape="strict" kind="html"} {template .ReplacePatchSetHtml autoescape="strict" kind="html"}
<p> <p>
<strong>{$fromName}</strong> uploaded patch set{sp} {$fromName} uploaded patch set #{$patchSet.patchSetId} to{sp}
<strong>#{$patchSet.patchSetId}</strong> to{sp}
<strong>{$change.subject}</strong>. <strong>{$change.subject}</strong>.
</p> </p>

View File

@@ -24,8 +24,7 @@
*/ */
{template .RestoredHtml autoescape="strict" kind="html"} {template .RestoredHtml autoescape="strict" kind="html"}
<p> <p>
<strong>{$fromName}</strong> restored{sp} {$fromName} restored <strong>{$change.subject}</strong>.
<strong>{$change.subject}</strong>.
</p> </p>
{if $email.changeUrl} {if $email.changeUrl}

View File

@@ -24,8 +24,7 @@
*/ */
{template .RevertedHtml autoescape="strict" kind="html"} {template .RevertedHtml autoescape="strict" kind="html"}
<p> <p>
<strong>{$fromName}</strong> reverted the change:{sp} {$fromName} reverted the change: <strong>{$change.subject}</strong>.
<strong>{$change.subject}</strong>.
</p> </p>
{if $email.changeUrl} {if $email.changeUrl}