diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java index b01527425a..e744239238 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java @@ -28,9 +28,9 @@ import com.google.gwt.user.client.ui.FocusPanel; import com.google.gwt.user.client.ui.Grid; import com.google.gwt.user.client.ui.HTMLTable.CellFormatter; import com.google.gwt.user.client.ui.HasHorizontalAlignment; +import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwtexpui.safehtml.client.SafeHtml; import com.google.gwtexpui.safehtml.client.SafeHtmlBuilder; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; import java.util.ArrayList; import java.util.Collection; @@ -42,7 +42,7 @@ import java.util.List; import java.util.Map; -public class KeyHelpPopup extends PluginSafePopupPanel implements +public class KeyHelpPopup extends PopupPanel implements KeyPressHandler, KeyDownHandler { private final FocusPanel focus; diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/AutoCenterDialogBox.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/AutoCenterDialogBox.java index 78ea8d607e..54d8eca6f2 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/AutoCenterDialogBox.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/AutoCenterDialogBox.java @@ -18,9 +18,10 @@ import com.google.gwt.event.logical.shared.ResizeEvent; import com.google.gwt.event.logical.shared.ResizeHandler; import com.google.gwt.event.shared.HandlerRegistration; import com.google.gwt.user.client.Window; +import com.google.gwt.user.client.ui.DialogBox; /** A DialogBox that automatically re-centers itself if the window changes */ -public class AutoCenterDialogBox extends PluginSafeDialogBox { +public class AutoCenterDialogBox extends DialogBox { private HandlerRegistration recenter; public AutoCenterDialogBox() { diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleEvent.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleEvent.java deleted file mode 100644 index 74218b4bfc..0000000000 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleEvent.java +++ /dev/null @@ -1,60 +0,0 @@ -// Copyright (C) 2013 The Android Open Source Project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package com.google.gwtexpui.user.client; - -import com.google.gwt.event.shared.GwtEvent; -import com.google.gwt.user.client.ui.Widget; - -public class DialogVisibleEvent extends GwtEvent { - private static Type TYPE; - - public static Type getType() { - if (TYPE == null) { - TYPE = new Type<>(); - } - return TYPE; - } - - private final Widget parent; - private final boolean visible; - - DialogVisibleEvent(Widget w, boolean visible) { - this.parent = w; - this.visible = visible; - } - - public boolean contains(Widget c) { - for (; c != null; c = c.getParent()) { - if (c == parent) { - return true; - } - } - return false; - } - - public boolean isVisible() { - return visible; - } - - @Override - public Type getAssociatedType() { - return getType(); - } - - @Override - protected void dispatch(DialogVisibleHandler handler) { - handler.onDialogVisible(this); - } -} diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleHandler.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleHandler.java deleted file mode 100644 index d242db6311..0000000000 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleHandler.java +++ /dev/null @@ -1,21 +0,0 @@ -// Copyright (C) 2013 The Android Open Source Project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package com.google.gwtexpui.user.client; - -import com.google.gwt.event.shared.EventHandler; - -public interface DialogVisibleHandler extends EventHandler { - public void onDialogVisible(DialogVisibleEvent event); -} diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/PluginSafeDialogBox.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/PluginSafeDialogBox.java deleted file mode 100644 index 80bfba12b3..0000000000 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/PluginSafeDialogBox.java +++ /dev/null @@ -1,61 +0,0 @@ -// Copyright (C) 2009 The Android Open Source Project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package com.google.gwtexpui.user.client; - -import com.google.gwt.user.client.ui.DialogBox; - -/** - * A DialogBox that can appear over Flash movies and Java applets. - *

- * Some browsers have issues with placing a <div> (such as that used by - * the DialogBox implementation) over top of native UI such as that used by the - * Flash plugin. Often the native UI leaks over top of the <div>, which is - * not the desired behavior for a dialog box. - *

- * This implementation hides the native resources by setting their display - * property to 'none' when the dialog is shown, and restores them back to their - * prior setting when the dialog is hidden. - * */ -public class PluginSafeDialogBox extends DialogBox { - public PluginSafeDialogBox() { - this(false); - } - - public PluginSafeDialogBox(final boolean autoHide) { - this(autoHide, true); - } - - public PluginSafeDialogBox(final boolean autoHide, final boolean modal) { - super(autoHide, modal); - } - - @Override - public void setVisible(final boolean show) { - UserAgent.fireDialogVisible(this, show); - super.setVisible(show); - } - - @Override - public void show() { - UserAgent.fireDialogVisible(this, true); - super.show(); - } - - @Override - public void hide(final boolean autoClosed) { - UserAgent.fireDialogVisible(this, false); - super.hide(autoClosed); - } -} diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/PluginSafePopupPanel.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/PluginSafePopupPanel.java deleted file mode 100644 index 1ed8f99f0d..0000000000 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/PluginSafePopupPanel.java +++ /dev/null @@ -1,61 +0,0 @@ -// Copyright (C) 2009 The Android Open Source Project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package com.google.gwtexpui.user.client; - -import com.google.gwt.user.client.ui.PopupPanel; - -/** - * A PopupPanel that can appear over Flash movies and Java applets. - *

- * Some browsers have issues with placing a <div> (such as that used by - * the PopupPanel implementation) over top of native UI such as that used by the - * Flash plugin. Often the native UI leaks over top of the <div>, which is - * not the desired behavior for a dialog box. - *

- * This implementation hides the native resources by setting their display - * property to 'none' when the dialog is shown, and restores them back to their - * prior setting when the dialog is hidden. - * */ -public class PluginSafePopupPanel extends PopupPanel { - public PluginSafePopupPanel() { - this(false); - } - - public PluginSafePopupPanel(final boolean autoHide) { - this(autoHide, true); - } - - public PluginSafePopupPanel(final boolean autoHide, final boolean modal) { - super(autoHide, modal); - } - - @Override - public void setVisible(final boolean show) { - UserAgent.fireDialogVisible(this, show); - super.setVisible(show); - } - - @Override - public void show() { - UserAgent.fireDialogVisible(this, true); - super.show(); - } - - @Override - public void hide(final boolean autoClosed) { - UserAgent.fireDialogVisible(this, false); - super.hide(autoClosed); - } -} diff --git a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/UserAgent.java b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/UserAgent.java index c6549026e2..02ba9aeac5 100644 --- a/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/UserAgent.java +++ b/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/UserAgent.java @@ -15,11 +15,7 @@ package com.google.gwtexpui.user.client; import com.google.gwt.core.client.GWT; -import com.google.gwt.event.shared.EventBus; -import com.google.gwt.event.shared.HandlerRegistration; -import com.google.gwt.event.shared.SimpleEventBus; import com.google.gwt.user.client.Window; -import com.google.gwt.user.client.ui.Widget; /** * User agent feature tests we don't create permutations for. @@ -33,16 +29,6 @@ import com.google.gwt.user.client.ui.Widget; public class UserAgent { /** Does the browser have ShockwaveFlash plugin enabled? */ public static final boolean hasFlash = hasFlash(); - private static final EventBus bus = new SimpleEventBus(); - - public static HandlerRegistration addDialogVisibleHandler( - DialogVisibleHandler handler) { - return bus.addHandler(DialogVisibleEvent.getType(), handler); - } - - static void fireDialogVisible(Widget w, boolean visible) { - bus.fireEvent(new DialogVisibleEvent(w, visible)); - } private static native boolean hasFlash() /*-{ diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ErrorDialog.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ErrorDialog.java index 700c701fb7..a5c5659ba5 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ErrorDialog.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ErrorDialog.java @@ -26,13 +26,13 @@ import com.google.gwt.user.client.rpc.StatusCodeException; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.Label; +import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.Widget; import com.google.gwtexpui.safehtml.client.SafeHtml; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; import com.google.gwtjsonrpc.client.RemoteJsonException; /** A dialog box showing an error message, when bad things happen. */ -public class ErrorDialog extends PluginSafePopupPanel { +public class ErrorDialog extends PopupPanel { private final Label text; private final FlowPanel body; private final Button closey; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/NotSignedInDialog.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/NotSignedInDialog.java index 83c32cd5eb..a372f035bd 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/NotSignedInDialog.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/NotSignedInDialog.java @@ -26,10 +26,9 @@ import com.google.gwt.user.client.ui.HTML; import com.google.gwt.user.client.ui.Label; import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwtexpui.globalkey.client.GlobalKey; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; /** A dialog box telling the user they are not signed in. */ -public class NotSignedInDialog extends PluginSafePopupPanel implements CloseHandler { +public class NotSignedInDialog extends PopupPanel implements CloseHandler { private Button signin; private boolean buttonClicked; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/UserPopupPanel.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/UserPopupPanel.java index 90348dba55..cfb7e9217a 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/UserPopupPanel.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/UserPopupPanel.java @@ -23,10 +23,10 @@ import com.google.gwt.dom.client.Element; import com.google.gwt.uibinder.client.UiBinder; import com.google.gwt.uibinder.client.UiField; import com.google.gwt.user.client.ui.Label; +import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.Widget; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; -public class UserPopupPanel extends PluginSafePopupPanel { +public class UserPopupPanel extends PopupPanel { interface Binder extends UiBinder {} private static final Binder binder = GWT.create(Binder.class); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PopupHelper.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PopupHelper.java index 95d010cdf7..5f28e14290 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PopupHelper.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PopupHelper.java @@ -22,7 +22,6 @@ import com.google.gwt.event.logical.shared.CloseHandler; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwtexpui.globalkey.client.GlobalKey; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; class PopupHelper { static PopupHelper popup(ActionContext ctx, Element panel) { @@ -34,7 +33,7 @@ class PopupHelper { private final ActionButton activatingButton; private final FlowPanel panel; - private PluginSafePopupPanel popup; + private PopupPanel popup; PopupHelper(ActionButton button, Element child) { activatingButton = button; @@ -44,7 +43,7 @@ class PopupHelper { } void show() { - final PluginSafePopupPanel p = new PluginSafePopupPanel(true); + final PopupPanel p = new PopupPanel(true); p.setStyleName(Resources.I.style().popup()); p.addAutoHidePartner(activatingButton.getElement()); p.addCloseHandler(new CloseHandler() { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ActionMessageBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ActionMessageBox.java index c560f6d905..28943ab018 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ActionMessageBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ActionMessageBox.java @@ -30,7 +30,6 @@ import com.google.gwt.user.client.ui.HTMLPanel; import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwtexpui.globalkey.client.GlobalKey; import com.google.gwtexpui.globalkey.client.NpTextArea; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; abstract class ActionMessageBox extends Composite { interface Binder extends UiBinder {} @@ -41,7 +40,7 @@ abstract class ActionMessageBox extends Composite { } private final Button activatingButton; - private PluginSafePopupPanel popup; + private PopupPanel popup; @UiField Style style; @UiField NpTextArea message; @@ -62,7 +61,7 @@ abstract class ActionMessageBox extends Composite { return; } - final PluginSafePopupPanel p = new PluginSafePopupPanel(true); + final PopupPanel p = new PopupPanel(true); p.setStyleName(style.popup()); p.addAutoHidePartner(activatingButton.getElement()); p.addCloseHandler(new CloseHandler() { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileAction.java index f74ebf67e5..0b6c5cd123 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileAction.java @@ -21,7 +21,6 @@ import com.google.gwt.event.logical.shared.CloseHandler; import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.Widget; import com.google.gwtexpui.globalkey.client.GlobalKey; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; class AddFileAction { private final Change.Id changeId; @@ -54,7 +53,7 @@ class AddFileAction { } addBox.clearPath(); - final PluginSafePopupPanel p = new PluginSafePopupPanel(true); + final PopupPanel p = new PopupPanel(true); p.setStyleName(style.replyBox()); p.addAutoHidePartner(addButton.getElement()); p.addCloseHandler(new CloseHandler() { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileAction.java index ee94564368..49e08aa92c 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileAction.java @@ -21,7 +21,6 @@ import com.google.gwt.event.logical.shared.CloseHandler; import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.Widget; import com.google.gwtexpui.globalkey.client.GlobalKey; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; class DeleteFileAction { private final Change.Id changeId; @@ -51,7 +50,7 @@ class DeleteFileAction { } deleteBox.clearPath(); - final PluginSafePopupPanel p = new PluginSafePopupPanel(true); + final PopupPanel p = new PopupPanel(true); p.setStyleName(style.replyBox()); p.addAutoHidePartner(deleteButton.getElement()); p.addCloseHandler(new CloseHandler() { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileAction.java index 1f11e6542f..17b218d279 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileAction.java @@ -21,7 +21,6 @@ import com.google.gwt.event.logical.shared.CloseHandler; import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.Widget; import com.google.gwtexpui.globalkey.client.GlobalKey; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; class RenameFileAction { private final Change.Id changeId; @@ -51,7 +50,7 @@ class RenameFileAction { } renameBox.clearPath(); - final PluginSafePopupPanel p = new PluginSafePopupPanel(true); + final PopupPanel p = new PopupPanel(true); p.setStyleName(style.replyBox()); p.addAutoHidePartner(renameButton.getElement()); p.addCloseHandler(new CloseHandler() { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java index 6e409790d8..29622d5d70 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java @@ -28,7 +28,6 @@ import com.google.gwt.user.client.Window; import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.Widget; import com.google.gwtexpui.globalkey.client.GlobalKey; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; class ReplyAction { private final PatchSet.Id psId; @@ -102,7 +101,7 @@ class ReplyAction { replyBox.replyTo(msg); } - final PluginSafePopupPanel p = new PluginSafePopupPanel(true, false); + final PopupPanel p = new PopupPanel(true, false); p.setStyleName(style.replyBox()); p.addAutoHidePartner(replyButton.getElement()); p.addAutoHidePartner(quickApproveButton.getElement()); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java index 1bf6f6c5a7..a3b16f9195 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java @@ -23,7 +23,6 @@ import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.UIObject; import com.google.gwt.user.client.ui.Widget; import com.google.gwtexpui.globalkey.client.GlobalKey; -import com.google.gwtexpui.user.client.PluginSafePopupPanel; abstract class RightSidePopdownAction { private final ChangeScreen.Style style; @@ -49,7 +48,7 @@ abstract class RightSidePopdownAction { return; } - final PluginSafePopupPanel p = new PluginSafePopupPanel(true) { + final PopupPanel p = new PopupPanel(true) { @Override public void setPopupPosition(int left, int top) { top -= Document.get().getBodyOffsetTop(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchBrowserPopup.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchBrowserPopup.java index e60ce76909..2962fb1191 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchBrowserPopup.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchBrowserPopup.java @@ -22,14 +22,14 @@ import com.google.gwt.event.logical.shared.ResizeHandler; import com.google.gwt.event.shared.HandlerRegistration; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.Window; +import com.google.gwt.user.client.ui.DialogBox; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.PopupPanel.PositionCallback; import com.google.gwt.user.client.ui.ScrollPanel; import com.google.gwtexpui.globalkey.client.GlobalKey; import com.google.gwtexpui.globalkey.client.HidePopupPanelCommand; -import com.google.gwtexpui.user.client.PluginSafeDialogBox; -class PatchBrowserPopup extends PluginSafeDialogBox implements +class PatchBrowserPopup extends DialogBox implements PositionCallback, ResizeHandler { private final Patch.Key callerKey; private final PatchTable fileList; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ProjectListPopup.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ProjectListPopup.java index dc27790c5b..86c31f29f2 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ProjectListPopup.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ProjectListPopup.java @@ -25,6 +25,7 @@ import com.google.gwt.event.dom.client.KeyUpEvent; import com.google.gwt.event.dom.client.KeyUpHandler; import com.google.gwt.user.client.Window; import com.google.gwt.user.client.ui.Button; +import com.google.gwt.user.client.ui.DialogBox; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.Label; @@ -33,12 +34,11 @@ import com.google.gwt.user.client.ui.ScrollPanel; import com.google.gwtexpui.globalkey.client.GlobalKey; import com.google.gwtexpui.globalkey.client.HidePopupPanelCommand; import com.google.gwtexpui.globalkey.client.NpTextBox; -import com.google.gwtexpui.user.client.PluginSafeDialogBox; /** A popup containing all projects. */ public class ProjectListPopup { private HighlightingProjectsTable projectsTab; - private PluginSafeDialogBox popup; + private DialogBox popup; private NpTextBox filterTxt; private HorizontalPanel filterPanel; private String match; @@ -155,7 +155,7 @@ public class ProjectListPopup { } }); - popup = new PluginSafeDialogBox(); + popup = new DialogBox(); popup.setModal(false); popup.setText(popupText); }