From c499ed333b534629e0b99ee7f668597ca54a6ae3 Mon Sep 17 00:00:00 2001 From: Ben Rohlfs Date: Fri, 24 Jan 2020 12:18:58 +0100 Subject: [PATCH] Fix the alignment of the placeholder in reply dialog "Add reviewer..." was vertically not correctly positioned. Also reduce/align the vertical heights and margins a little, and use a little bit less space for the "Reviewers" and "CC" labels. Change-Id: I1ac7a64fb426218ee1ba0b4e999b7b29f4b4275d --- .../app/elements/change/gr-reply-dialog/gr-reply-dialog.html | 4 +--- .../app/elements/shared/gr-account-list/gr-account-list.html | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html index c177283d0a..d54669f07c 100644 --- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html @@ -86,19 +86,17 @@ limitations under the License. } .peopleList { display: flex; - padding-top: var(--spacing-xxs); } .peopleListLabel { color: var(--deemphasized-text-color); margin-top: var(--spacing-xs); - min-width: 7em; + min-width: 6em; padding-right: var(--spacing-m); } gr-account-list { display: flex; flex-wrap: wrap; flex: 1; - min-height: 1.8em; } #reviewerConfirmationOverlay { padding: var(--spacing-l); diff --git a/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.html b/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.html index 6103d6fb31..37591d815f 100644 --- a/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.html +++ b/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.html @@ -32,6 +32,7 @@ limitations under the License. display: flex; flex: 1; min-width: 10em; + margin: var(--spacing-xs) var(--spacing-xs) var(--spacing-xs) 0; } .group { --account-label-suffix: ' (group)';