Remove redundant 'final' and 'public' modifiers

Change-Id: I7567e42f1d8203037a2d5596acce0fc09475714b
This commit is contained in:
David Pursehouse
2017-01-28 21:36:26 +09:00
parent 1cd287ee77
commit c4f1aec9c2
11 changed files with 12 additions and 12 deletions

View File

@@ -34,5 +34,5 @@ public interface PatchSetWebLink extends WebLink {
* @return WebLinkInfo that links to patch set in external service, * @return WebLinkInfo that links to patch set in external service,
* null if there should be no link. * null if there should be no link.
*/ */
WebLinkInfo getPatchSetWebLink(final String projectName, final String commit); WebLinkInfo getPatchSetWebLink(String projectName, String commit);
} }

View File

@@ -70,7 +70,7 @@ public abstract class AccountGroupScreen extends MenuScreen {
}); });
} }
protected abstract void display(final GroupInfo group, final boolean canModify); protected abstract void display(GroupInfo group, boolean canModify);
protected AccountGroup.UUID getGroupUUID() { protected AccountGroup.UUID getGroupUUID() {
return group.getGroupUUID(); return group.getGroupUUID();

View File

@@ -88,7 +88,7 @@ abstract class ChunkManager {
} }
} }
abstract Runnable diffChunkNav(final CodeMirror cm, final Direction dir); abstract Runnable diffChunkNav(CodeMirror cm, Direction dir);
void diffChunkNavHelper(List<? extends DiffChunkInfo> chunks, void diffChunkNavHelper(List<? extends DiffChunkInfo> chunks,
DiffScreen host, int res, Direction dir) { DiffScreen host, int res, Direction dir) {

View File

@@ -778,7 +778,7 @@ abstract class DiffScreen extends Screen {
this.prefsAction = prefsAction; this.prefsAction = prefsAction;
} }
abstract void operation(final Runnable apply); abstract void operation(Runnable apply);
private Runnable upToChange(final boolean openReplyBox) { private Runnable upToChange(final boolean openReplyBox) {
return new Runnable() { return new Runnable() {

View File

@@ -270,7 +270,7 @@ public class StarredChangesUtil {
public Set<Account.Id> byChange(final Change.Id changeId, public Set<Account.Id> byChange(final Change.Id changeId,
final String label) throws OrmException { final String label) throws OrmException {
try (final Repository repo = repoManager.openRepository(allUsers)) { try (Repository repo = repoManager.openRepository(allUsers)) {
return getRefNames(repo, RefNames.refsStarredChangesPrefix(changeId)) return getRefNames(repo, RefNames.refsStarredChangesPrefix(changeId))
.stream() .stream()
.map(Account.Id::parse) .map(Account.Id::parse)

View File

@@ -33,7 +33,7 @@ class LimitedByteArrayOutputStream extends OutputStream {
* @param max the maximum size in bytes which may be stored. * @param max the maximum size in bytes which may be stored.
* @param initial the initial size. It must be smaller than the max size. * @param initial the initial size. It must be smaller than the max size.
*/ */
public LimitedByteArrayOutputStream(int max, int initial) { LimitedByteArrayOutputStream(int max, int initial) {
checkArgument(initial <= max); checkArgument(initial <= max);
maxSize = max; maxSize = max;
buffer = new ByteArrayOutputStream(initial); buffer = new ByteArrayOutputStream(initial);

View File

@@ -37,7 +37,7 @@ import java.util.Map;
*/ */
@ExtensionPoint @ExtensionPoint
public interface OnSubmitValidationListener { public interface OnSubmitValidationListener {
public class Arguments { class Arguments {
private Project.NameKey project; private Project.NameKey project;
private Repository repository; private Repository repository;
private ObjectReader objectReader; private ObjectReader objectReader;

View File

@@ -31,7 +31,7 @@ public interface FileTypeRegistry {
* or cannot be determined, {@link MimeUtil2#UNKNOWN_MIME_TYPE} which * or cannot be determined, {@link MimeUtil2#UNKNOWN_MIME_TYPE} which
* is an alias for {@code application/octet-stream}. * is an alias for {@code application/octet-stream}.
*/ */
MimeType getMimeType(final String path, final byte[] content); MimeType getMimeType(String path, byte[] content);
/** /**
* Is this content type safe to transmit to a browser directly? * Is this content type safe to transmit to a browser directly?
@@ -42,6 +42,6 @@ public interface FileTypeRegistry {
* content type and wants it to be protected (typically by wrapping * content type and wants it to be protected (typically by wrapping
* the data in a ZIP archive). * the data in a ZIP archive).
*/ */
boolean isSafeInline(final MimeType type); boolean isSafeInline(MimeType type);
} }

View File

@@ -63,7 +63,7 @@ public class DeleteRef {
private String prefix; private String prefix;
public interface Factory { public interface Factory {
public DeleteRef create(ProjectResource r); DeleteRef create(ProjectResource r);
} }
@AssistedInject @AssistedInject

View File

@@ -26,7 +26,7 @@ import java.util.TreeSet;
/** Node of a Project in a tree formatted by {@link ListProjects}. */ /** Node of a Project in a tree formatted by {@link ListProjects}. */
public class ProjectNode implements TreeNode, Comparable<ProjectNode> { public class ProjectNode implements TreeNode, Comparable<ProjectNode> {
public interface Factory { public interface Factory {
ProjectNode create(final Project project, final boolean isVisible); ProjectNode create(Project project, boolean isVisible);
} }
private final AllProjectsName allProjectsName; private final AllProjectsName allProjectsName;

View File

@@ -178,7 +178,7 @@ public abstract class RequestScopePropagator {
/** /**
* @see #wrap(Callable) * @see #wrap(Callable)
*/ */
protected abstract <T> Callable<T> wrapImpl(final Callable<T> callable); protected abstract <T> Callable<T> wrapImpl(Callable<T> callable);
protected <T> Callable<T> context(final RequestContext context, protected <T> Callable<T> context(final RequestContext context,
final Callable<T> callable) { final Callable<T> callable) {