diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/RefPatternMatcher.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/RefPatternMatcher.java index dcf684198f..d882e0dac1 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/RefPatternMatcher.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/RefPatternMatcher.java @@ -110,13 +110,24 @@ public abstract class RefPatternMatcher { u = username; } - RefPatternMatcher next = - getMatcher(template.replace(Collections.singletonMap("username", u))); - return next != null && next.match(ref, username); + RefPatternMatcher next = getMatcher(expand(template, u)); + return next != null ? next.match(expand(ref, u), username) : false; } boolean matchPrefix(String ref) { return ref.startsWith(prefix); } + + private String expand(String parameterizedRef, String userName) { + if (parameterizedRef.contains("${")) { + return expand(new ParameterizedString(parameterizedRef), userName); + } + return parameterizedRef; + } + + private String expand(ParameterizedString parameterizedRef, String userName) { + return parameterizedRef.replace(Collections.singletonMap("username", + userName)); + } } } diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java index 54765ac558..74156dd226 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java @@ -255,6 +255,13 @@ public class RefControlTest { u.controlForRef("refs/heads/master").canUpload()); } + @Test + public void testUsernamePatternCanUploadToAnyRef() { + grant(local, PUSH, REGISTERED_USERS, "refs/heads/users/${username}/*"); + ProjectControl u = util.user(local, "a-registered-user"); + assertTrue("can upload", u.canPushToAtLeastOneRef() == Capable.OK); + } + @Test public void testUsernamePatternNonRegex() { grant(local, READ, DEVS, "refs/sb/${username}/heads/*");