opendev/gerrit
Code Issues Proposed changes

Fix: Text boxes on "Create Branch" panel extend beyond container

Browse Source 
On some combinations of OS and browser, the "Branch Name" and "Initial
Revision" text boxes in the "Create Branch" screen extend beyond their
container.

Explicitly set the width of the container to prevent this from happening.

Change-Id: I99ab5986dab9f130861d873feb79be6ef2876ff6
This commit is contained in:
Bruce Zu
2013-01-16 15:06:16 +08:00
committed by David Pursehouse
parent d18ef139f3
commit c654b70a57
3 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritCss.java
View File

@@ -31,6 +31,7 @@ public interface GerritCss extends CssResource {
String addReviewer(); String addReviewer();
String removeReviewer(); String removeReviewer();
String removeReviewerCell(); String removeReviewerCell();
String addBranch();
String addSshKeyPanel(); String addSshKeyPanel();
String addWatchPanel(); String addWatchPanel();
String approvalCategoryList(); String approvalCategoryList();

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java
View File

@@ -106,13 +106,13 @@ public class ProjectBranchesScreen extends ProjectScreen {
super.onInitUI(); super.onInitUI();
addPanel = new FlowPanel(); addPanel = new FlowPanel();
addPanel.setStyleName(Gerrit.RESOURCES.css().addSshKeyPanel());
addPanel.setWidth("35em");
final Grid addGrid = new Grid(2, 2); final Grid addGrid = new Grid(2, 2);
addGrid.setStyleName(Gerrit.RESOURCES.css().addBranch());
final int texBoxLength = 50;
nameTxtBox = new HintTextBox(); nameTxtBox = new HintTextBox();
nameTxtBox.setVisibleLength(50); nameTxtBox.setVisibleLength(texBoxLength);
nameTxtBox.setHintText(Util.C.defaultBranchName()); nameTxtBox.setHintText(Util.C.defaultBranchName());
nameTxtBox.addKeyPressHandler(new KeyPressHandler() { nameTxtBox.addKeyPressHandler(new KeyPressHandler() {
@Override @Override
@@ -126,7 +126,7 @@ public class ProjectBranchesScreen extends ProjectScreen {
addGrid.setWidget(0, 1, nameTxtBox); addGrid.setWidget(0, 1, nameTxtBox);
irevTxtBox = new HintTextBox(); irevTxtBox = new HintTextBox();
irevTxtBox.setVisibleLength(50); irevTxtBox.setVisibleLength(texBoxLength);
irevTxtBox.setHintText(Util.C.defaultRevisionSpec()); irevTxtBox.setHintText(Util.C.defaultRevisionSpec());
irevTxtBox.addKeyPressHandler(new KeyPressHandler() { irevTxtBox.addKeyPressHandler(new KeyPressHandler() {
@Override @Override

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css
View File

@@ -1235,6 +1235,12 @@ a:hover.downloadLink {
color: grey; color: grey;
} }
.addBranch {
margin-top: 10px;
background-color: trimColor;
padding: 5px 5px 5px 5px;
}
.addSshKeyPanel { .addSshKeyPanel {
margin-top: 10px; margin-top: 10px;
background-color: trimColor; background-color: trimColor;