From c6857c537c971385df4a4adedbee0318fc23e233 Mon Sep 17 00:00:00 2001 From: Andrew Bonventre Date: Tue, 29 Mar 2016 17:16:09 -0400 Subject: [PATCH] Fix var scoping issue while doing intraline highlights + I hate var scoping in JS. + Also update server.go to point to Gerrit. Change-Id: I9bb035cd7eca5d5c029052611ea28b7d67fd6f98 --- polygerrit-ui/app/elements/diff/gr-diff/gr-diff-builder.js | 4 ++-- polygerrit-ui/server.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff-builder.js b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff-builder.js index 338845e397..f5e7c4c3fc 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff-builder.js +++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff-builder.js @@ -95,7 +95,7 @@ } if (group[GrDiffBuilder.GroupType.REMOVED] !== undefined) { - var highlights; + var highlights = undefined; if (group[GrDiffBuilder.Highlights.REMOVED] !== undefined) { highlights = this._normalizeIntralineHighlights( group[GrDiffBuilder.GroupType.REMOVED], @@ -106,7 +106,7 @@ } if (group[GrDiffBuilder.GroupType.ADDED] !== undefined) { - var highlights; + var highlights = undefined; if (group[GrDiffBuilder.Highlights.ADDED] !== undefined) { highlights = this._normalizeIntralineHighlights( group[GrDiffBuilder.GroupType.ADDED], diff --git a/polygerrit-ui/server.go b/polygerrit-ui/server.go index a7ec44c76e..59a09b088c 100644 --- a/polygerrit-ui/server.go +++ b/polygerrit-ui/server.go @@ -30,7 +30,7 @@ import ( ) var ( - restHost = flag.String("host", "canary-chromium-review.googlesource.com", "Host to proxy requests to") + restHost = flag.String("host", "gerrit-review.googlesource.com", "Host to proxy requests to") port = flag.String("port", ":8081", "Port to serve HTTP requests on") prod = flag.Bool("prod", false, "Serve production assets") loggedIn = flag.Bool("logged_in", false, "Return user info as if the user is logged in")