From c73b47148ce4688d451acf40a66cd77ada5176e9 Mon Sep 17 00:00:00 2001
From: Steffen Gebert <steffen.gebert@typo3.org>
Date: Tue, 1 Jan 2013 18:32:19 +0100
Subject: [PATCH] Add an "Add Comment" button to change screen

It is hard to spot for novice gerrit users, how they can an comment to a
change when seeing the comments of other people.

As a relief, add an "Add Comment" button below existing comments.

Change-Id: I2d284cfbe1860e03304f907e0badeb3b87999994
---
 .../gerrit/client/changes/ChangeConstants.java       |  1 +
 .../gerrit/client/changes/ChangeConstants.properties |  1 +
 .../google/gerrit/client/changes/ChangeScreen.java   | 12 ++++++++++++
 3 files changed, 14 insertions(+)

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
index 1d08ac95c9..e3f7c97644 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
@@ -79,6 +79,7 @@ public interface ChangeConstants extends Constants {
   String changeScreenDependsOn();
   String changeScreenNeededBy();
   String changeScreenComments();
+  String changeScreenAddComment();
 
   String approvalTableReviewer();
   String approvalTableAddReviewer();
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
index 3a4edffefd..c236b181ce 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
@@ -56,6 +56,7 @@ changeScreenDependencies =  Dependencies
 changeScreenDependsOn = Depends On
 changeScreenNeededBy = Needed By
 changeScreenComments = Comments
+changeScreenAddComment = Add Comment
 
 approvalTableReviewer = Reviewer
 approvalTableAddReviewer = Add Reviewer
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
index e53beeae04..3dcd5d9f13 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
@@ -33,11 +33,14 @@ import com.google.gerrit.reviewdb.client.ChangeMessage;
 import com.google.gerrit.reviewdb.client.PatchSet;
 import com.google.gwt.event.dom.client.ChangeEvent;
 import com.google.gwt.event.dom.client.ChangeHandler;
+import com.google.gwt.event.dom.client.ClickEvent;
+import com.google.gwt.event.dom.client.ClickHandler;
 import com.google.gwt.event.dom.client.KeyPressEvent;
 import com.google.gwt.event.logical.shared.ValueChangeEvent;
 import com.google.gwt.event.logical.shared.ValueChangeHandler;
 import com.google.gwt.event.shared.HandlerRegistration;
 import com.google.gwt.i18n.client.LocaleInfo;
+import com.google.gwt.user.client.ui.Button;
 import com.google.gwt.user.client.ui.DisclosurePanel;
 import com.google.gwt.user.client.ui.FlowPanel;
 import com.google.gwt.user.client.ui.Grid;
@@ -400,6 +403,15 @@ public class ChangeScreen extends Screen
       comments.add(cp);
     }
 
+    final Button b = new Button(Util.C.changeScreenAddComment());
+    b.addClickHandler(new ClickHandler() {
+        @Override
+        public void onClick(final ClickEvent event) {
+            PatchSet.Id currentPatchSetId = patchSetsBlock.getCurrentPatchSet().getId();
+            Gerrit.display(Dispatcher.toPublish(currentPatchSetId));
+        }
+    });
+    comments.add(b);
     comments.setVisible(msgList.size() > 0);
   }