opendev/gerrit
Code Issues Proposed changes

Rename "topic:" to "intopic:" and "exacttopic:" to "topic:"

Browse Source 
"Exact topic" is unwieldy to say/type. We wanted to get the change
that introduced it in faster so we could fix the correctness issue
with submitWholeTopic and get the schema upgrade process started. Now
we can go back and change the names to something more sensible.

The new name "intopic" is shorter and parallels the standard Google
search operator "inurl".

Change-Id: Ic7a41947392f24752a5524ad8365c0453c931a8b
This commit is contained in:
Dave Borowitz
2015-06-01 10:00:04 -07:00
parent 3736824e98
commit c751799f6d
12 changed files with 25 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gerrit-server/src/test/java/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java
View File

@@ -453,14 +453,14 @@ public abstract class AbstractQueryChangesTest {
Change change5 = newChange(repo, null, null, null, null).insert();
assertQuery("topic:foo");
assertQuery("topic:feature1", change1);
assertQuery("topic:feature2", change4, change3, change2);
assertQuery("exacttopic:feature2", change2);
assertQuery("topic:feature2", change4, change3, change2);
assertQuery("topic:fixup", change4);
assertQuery("exacttopic:\"\"", change5);
assertQuery("intopic:foo");
assertQuery("intopic:feature1", change1);
assertQuery("intopic:feature2", change4, change3, change2);
assertQuery("topic:feature2", change2);
assertQuery("intopic:feature2", change4, change3, change2);
assertQuery("intopic:fixup", change4);
assertQuery("topic:\"\"", change5);
assertQuery("intopic:\"\"", change5);
}
@Test