opendev/gerrit
Code Issues Proposed changes

Avoid reloading the group after successful rename

Browse Source 
The call to the server is not needed since all information to update
the UI is already locally available.

Change-Id: I7d59dc601fa3afd6ccc55f1d9d8b0b5b59606354
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-02-01 07:41:43 +01:00
parent e76b3c19f9
commit c7d0e84961
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupInfoScreen.java
View File

@@ -14,7 +14,6 @@
package com.google.gerrit.client.admin; package com.google.gerrit.client.admin;
import com.google.gerrit.client.Dispatcher;
import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.VoidResult; import com.google.gerrit.client.VoidResult;
import com.google.gerrit.client.groups.GroupApi; import com.google.gerrit.client.groups.GroupApi;
@@ -99,7 +98,12 @@ public class AccountGroupInfoScreen extends AccountGroupScreen {
GroupApi.renameGroup(getGroupUUID(), newName, GroupApi.renameGroup(getGroupUUID(), newName,
new GerritCallback<com.google.gerrit.client.VoidResult>() { new GerritCallback<com.google.gerrit.client.VoidResult>() {
public void onSuccess(final com.google.gerrit.client.VoidResult result) { public void onSuccess(final com.google.gerrit.client.VoidResult result) {
Gerrit.display(Dispatcher.toGroup(getGroupUUID(), AccountGroupScreen.INFO)); saveName.setEnabled(false);
setPageTitle(Util.M.group(newName));
groupNameTxt.setText(newName);
if (getGroupUUID().equals(getOwnerGroupUUID())) {
ownerTxt.setText(newName);
}
} }
}); });
} }

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupScreen.java
View File

@@ -71,6 +71,10 @@ public abstract class AccountGroupScreen extends MenuScreen {
groupDetail.ownerGroup.setName(ownerGroup.name()); groupDetail.ownerGroup.setName(ownerGroup.name());
} }
protected AccountGroup.UUID getOwnerGroupUUID() {
return groupDetail.group.getOwnerGroupUUID();
}
protected void setMembersTabVisible(final boolean visible) { protected void setMembersTabVisible(final boolean visible) {
setLinkVisible(membersTabToken, visible); setLinkVisible(membersTabToken, visible);
} }