opendev/gerrit
Code Issues Proposed changes

Blur buttons within a comment thread after they are pressed

Browse Source 
This allows the user to still go back and forth with keyboard
shortcuts (otherwise the button eats them).

Bug: Issue 3854
Change-Id: I61c83a3278365a6cc8f1f766af8cb80b59006118
This commit is contained in:
Andrew Bonventre
2016-01-28 16:08:06 -05:00
parent 349380e121
commit c899ec1f53
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
polygerrit-ui/app/elements/gr-diff-comment.html
View File

@@ -290,28 +290,28 @@ limitations under the License.
}, },
_handleReply: function(e) { _handleReply: function(e) {
e.preventDefault(); this._preventDefaultAndBlur(e);
this.fire('reply', {comment: this.comment}, {bubbles: false}); this.fire('reply', {comment: this.comment}, {bubbles: false});
}, },
_handleDone: function(e) { _handleDone: function(e) {
e.preventDefault(); this._preventDefaultAndBlur(e);
this.fire('done', {comment: this.comment}, {bubbles: false}); this.fire('done', {comment: this.comment}, {bubbles: false});
}, },
_handleEdit: function(e) { _handleEdit: function(e) {
e.preventDefault(); this._preventDefaultAndBlur(e);
this._editDraft = this.comment.message; this._editDraft = this.comment.message;
this.editing = true; this.editing = true;
}, },
_handleSave: function(e) { _handleSave: function(e) {
e.preventDefault(); this._preventDefaultAndBlur(e);
this.save(); this.save();
}, },
_handleCancel: function(e) { _handleCancel: function(e) {
e.preventDefault(); this._preventDefaultAndBlur(e);
if (this.comment.message == null || this.comment.message.length == 0) { if (this.comment.message == null || this.comment.message.length == 0) {
this.fire('discard', null, {bubbles: false}); this.fire('discard', null, {bubbles: false});
return; return;
@@ -321,7 +321,7 @@ limitations under the License.
}, },
_handleDiscard: function(e) { _handleDiscard: function(e) {
e.preventDefault(); this._preventDefaultAndBlur(e);
if (!this.comment.__draft) { if (!this.comment.__draft) {
throw Error('Cannot discard a non-draft comment.'); throw Error('Cannot discard a non-draft comment.');
} }
@@ -340,6 +340,11 @@ limitations under the License.
}.bind(this)); }.bind(this));
}, },
_preventDefaultAndBlur: function(e) {
e.preventDefault();
Polymer.dom(e).rootTarget.blur();
},
_send: function(method, url) { _send: function(method, url) {
var xhr = document.createElement('gr-request'); var xhr = document.createElement('gr-request');
var opts = { var opts = {