Suppress unused argument warnings in unavoidable cases

It would be nice if Eclipse were smart enough to ignore unused
argument warnings on @UiHandler and @Option methods, but alas it does
not. Suppressing these is ugly, but based on all the cleanup in the
previous commit, the benefit outweighs the cost.

Change-Id: I743917787ffb53be034eee3af2c525652fc18cb0
This commit is contained in:
Dave Borowitz
2014-10-28 14:31:44 -07:00
parent b942d0b0a2
commit c8d85ab5f4
30 changed files with 108 additions and 97 deletions

View File

@@ -109,17 +109,17 @@ public class AccessSectionEditor extends Composite implements
}
@UiHandler("deleteSection")
void onDeleteHover(MouseOverEvent event) {
void onDeleteHover(@SuppressWarnings("unused") MouseOverEvent event) {
normal.addClassName(AdminResources.I.css().deleteSectionHover());
}
@UiHandler("deleteSection")
void onDeleteNonHover(MouseOutEvent event) {
void onDeleteNonHover(@SuppressWarnings("unused") MouseOutEvent event) {
normal.removeClassName(AdminResources.I.css().deleteSectionHover());
}
@UiHandler("deleteSection")
void onDeleteSection(ClickEvent event) {
void onDeleteSection(@SuppressWarnings("unused") ClickEvent event) {
isDeleted = true;
if (name.isVisible()
@@ -139,7 +139,7 @@ public class AccessSectionEditor extends Composite implements
}
@UiHandler("undoDelete")
void onUndoDelete(ClickEvent event) {
void onUndoDelete(@SuppressWarnings("unused") ClickEvent event) {
isDeleted = false;
deleted.getStyle().setDisplay(Display.NONE);
normal.getStyle().setDisplay(Display.BLOCK);

View File

@@ -145,31 +145,31 @@ public class PermissionEditor extends Composite implements Editor<Permission>,
}
@UiHandler("deletePermission")
void onDeleteHover(MouseOverEvent event) {
void onDeleteHover(@SuppressWarnings("unused") MouseOverEvent event) {
addStyleName(AdminResources.I.css().deleteSectionHover());
}
@UiHandler("deletePermission")
void onDeleteNonHover(MouseOutEvent event) {
void onDeleteNonHover(@SuppressWarnings("unused") MouseOutEvent event) {
removeStyleName(AdminResources.I.css().deleteSectionHover());
}
@UiHandler("deletePermission")
void onDeletePermission(ClickEvent event) {
void onDeletePermission(@SuppressWarnings("unused") ClickEvent event) {
isDeleted = true;
normal.getStyle().setDisplay(Display.NONE);
deleted.getStyle().setDisplay(Display.BLOCK);
}
@UiHandler("undoDelete")
void onUndoDelete(ClickEvent event) {
void onUndoDelete(@SuppressWarnings("unused") ClickEvent event) {
isDeleted = false;
deleted.getStyle().setDisplay(Display.NONE);
normal.getStyle().setDisplay(Display.BLOCK);
}
@UiHandler("beginAddRule")
void onBeginAddRule(ClickEvent event) {
void onBeginAddRule(@SuppressWarnings("unused") ClickEvent event) {
beginAddRule();
}
@@ -186,7 +186,7 @@ public class PermissionEditor extends Composite implements Editor<Permission>,
}
@UiHandler("addRule")
void onAddGroupByClick(ClickEvent event) {
void onAddGroupByClick(@SuppressWarnings("unused") ClickEvent event) {
GroupReference ref = groupToAdd.getValue();
if (ref != null) {
addGroup(ref);
@@ -204,12 +204,13 @@ public class PermissionEditor extends Composite implements Editor<Permission>,
}
@UiHandler("groupToAdd")
void onAbortAddGroup(CloseEvent<GroupReferenceBox> event) {
void onAbortAddGroup(
@SuppressWarnings("unused") CloseEvent<GroupReferenceBox> event) {
hideAddGroup();
}
@UiHandler("hideAddGroup")
void hideAddGroup(ClickEvent event) {
void hideAddGroup(@SuppressWarnings("unused") ClickEvent event) {
hideAddGroup();
}

View File

@@ -176,14 +176,14 @@ public class PermissionRuleEditor extends Composite implements
}
@UiHandler("deleteRule")
void onDeleteRule(ClickEvent event) {
void onDeleteRule(@SuppressWarnings("unused") ClickEvent event) {
isDeleted = true;
normal.getStyle().setDisplay(Display.NONE);
deleted.getStyle().setDisplay(Display.BLOCK);
}
@UiHandler("undoDelete")
void onUndoDelete(ClickEvent event) {
void onUndoDelete(@SuppressWarnings("unused") ClickEvent event) {
isDeleted = false;
deleted.getStyle().setDisplay(Display.NONE);
normal.getStyle().setDisplay(Display.BLOCK);

View File

@@ -84,7 +84,7 @@ public class ProjectAccessEditor extends Composite implements
}
@UiHandler("addSection")
void onAddSection(ClickEvent event) {
void onAddSection(@SuppressWarnings("unused") ClickEvent event) {
int index = local.getList().size();
local.getList().add(new AccessSection("refs/heads/*"));

View File

@@ -159,7 +159,7 @@ public class ProjectAccessScreen extends ProjectScreen {
}
@UiHandler("edit")
void onEdit(ClickEvent event) {
void onEdit(@SuppressWarnings("unused") ClickEvent event) {
resetEditors();
edit.setEnabled(false);
@@ -184,12 +184,12 @@ public class ProjectAccessScreen extends ProjectScreen {
}
@UiHandler(value={"cancel1", "cancel2"})
void onCancel(ClickEvent event) {
void onCancel(@SuppressWarnings("unused") ClickEvent event) {
Gerrit.display(PageLinks.toProjectAcceess(getProjectKey()));
}
@UiHandler("commit")
void onCommit(ClickEvent event) {
void onCommit(@SuppressWarnings("unused") ClickEvent event) {
final ProjectAccess access = driver.flush();
if (driver.hasErrors()) {
@@ -267,7 +267,7 @@ public class ProjectAccessScreen extends ProjectScreen {
}
@UiHandler("review")
void onReview(ClickEvent event) {
void onReview(@SuppressWarnings("unused") ClickEvent event) {
final ProjectAccess access = driver.flush();
if (driver.hasErrors()) {