opendev/gerrit
Code Issues Proposed changes

Suppress unused argument warnings in unavoidable cases

Browse Source 
It would be nice if Eclipse were smart enough to ignore unused
argument warnings on @UiHandler and @Option methods, but alas it does
not. Suppressing these is ugly, but based on all the cleanup in the
previous commit, the benefit outweighs the cost.

Change-Id: I743917787ffb53be034eee3af2c525652fc18cb0
This commit is contained in:
Dave Borowitz
2014-10-28 14:31:44 -07:00
parent b942d0b0a2
commit c8d85ab5f4
30 changed files with 108 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAccessScreen.java
View File

@@ -159,7 +159,7 @@ public class ProjectAccessScreen extends ProjectScreen {
}
@UiHandler("edit")
void onEdit(ClickEvent event) {
void onEdit(@SuppressWarnings("unused") ClickEvent event) {
resetEditors();
edit.setEnabled(false);
@@ -184,12 +184,12 @@ public class ProjectAccessScreen extends ProjectScreen {
}
@UiHandler(value={"cancel1", "cancel2"})
void onCancel(ClickEvent event) {
void onCancel(@SuppressWarnings("unused") ClickEvent event) {
Gerrit.display(PageLinks.toProjectAcceess(getProjectKey()));
}
@UiHandler("commit")
void onCommit(ClickEvent event) {
void onCommit(@SuppressWarnings("unused") ClickEvent event) {
final ProjectAccess access = driver.flush();
if (driver.hasErrors()) {
@@ -267,7 +267,7 @@ public class ProjectAccessScreen extends ProjectScreen {
}
@UiHandler("review")
void onReview(ClickEvent event) {
void onReview(@SuppressWarnings("unused") ClickEvent event) {
final ProjectAccess access = driver.flush();
if (driver.hasErrors()) {