Merge changes I12783a82,Ic2ec2acb into stable-2.12

* changes:
  Allow to add custom core plugins in release build
  Maven: Split Maven repository settings out to a separate def file

plugins/BUCK

@@ -6,6 +6,9 @@ CORE = [
   'reviewnotes',
   'singleusergroup'
 ]
+CUSTOM = [
+  # Add custom core plugins here
+]
 
 # buck audit parses and resolves all deps even if not reachable
 # from the root(s) passed to audit. Filter dependencies to only
@@ -20,7 +23,7 @@ def core_plugins(names):
     else:
       n.append(p)
   return h, n
-HAVE, NEED = core_plugins(CORE)
+HAVE, NEED = core_plugins(CORE + CUSTOM)
 
 genrule(
   name = 'core',

tools/maven/BUCK

@@ -1,12 +1,14 @@
 include_defs('//VERSION')
 include_defs('//tools/maven/package.defs')
+include_defs('//tools/maven/repository.defs')
 
-URL = 'https://oss.sonatype.org/content/repositories/snapshots' \
+if GERRIT_VERSION.endswith('-SNAPSHOT'):
-      if GERRIT_VERSION.endswith('-SNAPSHOT') else \
+  URL = MAVEN_SNAPSHOT_URL
-        'https://oss.sonatype.org/service/local/staging/deploy/maven2'
+else:
+  URL = MAVEN_RELEASE_URL
 
 maven_package(
-  repository = 'sonatype-nexus-staging',
+  repository = MAVEN_REPOSITORY,
   url = URL,
   version = GERRIT_VERSION,
   jar = {

tools/maven/repository.defs

@@ -0,0 +1,3 @@
+MAVEN_REPOSITORY = 'sonatype-nexus-staging'
+MAVEN_SNAPSHOT_URL = 'https://oss.sonatype.org/content/repositories/snapshots'
+MAVEN_RELEASE_URL = 'https://oss.sonatype.org/service/local/staging/deploy/maven2'