diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/AbandonedHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/AbandonedHtml.soy index bda900b99f..30d40c9219 100644 --- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/AbandonedHtml.soy +++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/AbandonedHtml.soy @@ -24,7 +24,8 @@ */ {template .AbandonedHtml autoescape="strict" kind="html"}
- {$fromName} has abandoned this change. + {$fromName} abandoned{sp} + {$change.subject}.
{if $email.changeUrl} @@ -33,11 +34,6 @@ {/if} -- Change subject: {$change.subject} -
-{$coverLetter}
{/if}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ChangeFooterHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ChangeFooterHtml.soy
index 934ea18605..a0101c9f48 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ChangeFooterHtml.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ChangeFooterHtml.soy
@@ -27,9 +27,7 @@
*/
{template .ChangeFooterHtml autoescape="strict" kind="html"}
{let $footerStyle kind="css"}
- color: #555;
- font-size: 10px;
- margin: 10px 0 0 0;
+ display: none;
{/let}
{if $email.changeUrl or $email.settingsUrl}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentFooterHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentFooterHtml.soy
index f8f6c5ff68..84cace2a48 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentFooterHtml.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentFooterHtml.soy
@@ -21,9 +21,7 @@
*/
{template .CommentFooterHtml autoescape="strict" kind="html"}
{let $footerStyle kind="css"}
- color: #555;
- font-size: 10px;
- margin: 0;
+ display: none;
{/let}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentHtml.soy index 522bcc84d8..b55ef6ca9c 100644 --- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentHtml.soy +++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/CommentHtml.soy @@ -43,7 +43,8 @@ {/let}
- {$fromName} has posted comments on this change. + {$fromName} posted comments on{sp} + {$change.subject}.
{if $email.changeUrl} @@ -52,11 +53,6 @@ {/if} -- Change subject: {$change.subject} -
-{$coverLetter}
{/if}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteReviewerHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteReviewerHtml.soy
index e6830ec001..ead4071bc1 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteReviewerHtml.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteReviewerHtml.soy
@@ -24,12 +24,12 @@
*/
{template .DeleteReviewerHtml autoescape="strict" kind="html"}
- {$fromName} has removed{sp} + {$fromName} removed{sp} {foreach $reviewerName in $email.reviewerNames} {if not isFirst($reviewerName)},{sp}{/if} - {$reviewerName} + {$reviewerName} {/foreach}{sp} - from this change. + from {$change.subject}.
{if $email.changeUrl} @@ -38,11 +38,6 @@ {/if} -- Change subject: {$change.subject} -
-{$coverLetter}
{/if}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteVoteHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteVoteHtml.soy
index 6d88748ac8..4f74da940b 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteVoteHtml.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteVoteHtml.soy
@@ -24,7 +24,8 @@
*/
{template .DeleteVoteHtml autoescape="strict" kind="html"}
- {$fromName} removed a vote on this change. + {$fromName} removed a vote from{sp} + {$change.subject}.
{if $email.changeUrl} @@ -33,11 +34,6 @@ {/if} -- Change subject: {$change.subject} -
-{$coverLetter}
{/if}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/MergedHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/MergedHtml.soy
index 083e57d0a2..6ed8a8dc54 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/MergedHtml.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/MergedHtml.soy
@@ -23,7 +23,7 @@
*/
{template .MergedHtml autoescape="strict" kind="html"}
- {$fromName} has submitted this change and it was merged. + {$fromName} merged {$change.subject}.
{if $email.changeUrl} @@ -32,11 +32,6 @@ {/if} -- Change subject: {$change.subject} -
-
{$email.changeDetail}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/NewChangeHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/NewChangeHtml.soy
index 95ee41d79c..98a7c67aaa 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/NewChangeHtml.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/NewChangeHtml.soy
@@ -24,40 +24,27 @@
* @param projectName
*/
{template .NewChangeHtml autoescape="strict" kind="html"}
- {if $email.reviewerNames}
- - Hello{sp} - {foreach $reviewerName in $email.reviewerNames} - {if not isFirst($reviewerName)},{sp}{/if} - {$reviewerName} - {/foreach}, -
- -- I'd like you to do a code review. -
- - {if $email.changeUrl} -- Please visit this change to review. -
- {/if} - {else} -- {$fromName} has uploaded a new change for review. -
- - {if $email.changeUrl} -- {call .ViewChangeButton data="all" /} -
- {/if} - {/if} -- Change subject: {$change.subject} + {if $email.reviewerNames} + {$fromName} would like{sp} + {foreach $reviewerName in $email.reviewerNames} + {if not isFirst($reviewerName)} + {if isLast($reviewerName)}{sp}and{else},{/if}{sp} + {/if} + {$reviewerName} + {/foreach}{sp} + to review {$change.subject}. + {else} + {$fromName} uploaded{sp} + {$change.subject} for review. + {/if}
-+ {call .ViewChangeButton data="all" /} +
+ {/if}
{$email.changeDetail}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ReplacePatchSetHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ReplacePatchSetHtml.soy
index df00e2d897..92e2eef257 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ReplacePatchSetHtml.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ReplacePatchSetHtml.soy
@@ -24,40 +24,17 @@
* @param projectName
*/
{template .ReplacePatchSetHtml autoescape="strict" kind="html"}
- {if $email.reviewerNames}
-
- Hello{sp}
- {foreach $reviewerName in $email.reviewerNames}
- {$reviewerName},{sp}
- {/foreach}
-
-
-
- I'd like you to reexamine a change.
-
-
- {if $email.changeUrl}
-
- Please visit this change to look at{sp}
- the new patch set (#{$patchSet.patchSetId}).
-
- {/if}
- {else}
-
- {$fromName} has uploaded a new patch set (#{$patchSet.patchSetId}).
-
-
- {if $email.changeUrl}
-
- {call .ViewChangeButton data="all" /}
-
- {/if}
- {/if}
-
- Change subject: {$change.subject}
+ {$fromName} uploaded patch set{sp}
+ #{$patchSet.patchSetId} to{sp}
+ {$change.subject}.
-
+
+ {if $email.changeUrl}
+
+ {call .ViewChangeButton data="all" /}
+
+ {/if}
{$email.changeDetail}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/RestoredHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/RestoredHtml.soy
index 83b05c4814..4f249a7427 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/RestoredHtml.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/RestoredHtml.soy
@@ -24,7 +24,8 @@
*/
{template .RestoredHtml autoescape="strict" kind="html"}
- {$fromName} has restored this change.
+ {$fromName} restored{sp}
+ {$change.subject}.
{if $email.changeUrl}
@@ -33,11 +34,6 @@
{/if}
-
- Change subject: {$change.subject}
-
-
-
{if $coverLetter}
{$coverLetter}
{/if}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/RevertedHtml.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/RevertedHtml.soy
index c0dc4d35a1..fd6a222658 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/RevertedHtml.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/RevertedHtml.soy
@@ -24,7 +24,8 @@
*/
{template .RevertedHtml autoescape="strict" kind="html"}
- {$fromName} has reverted this change.
+ {$fromName} reverted the change:{sp}
+ {$change.subject}.
{if $email.changeUrl}
@@ -33,11 +34,6 @@
{/if}
-
- Change subject: {$change.subject}
-
-
-
{if $coverLetter}
{$coverLetter}
{/if}
diff --git a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ViewChangeButton.soy b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ViewChangeButton.soy
index defde55077..ab66eaa1ed 100644
--- a/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ViewChangeButton.soy
+++ b/gerrit-server/src/main/resources/com/google/gerrit/server/mail/ViewChangeButton.soy
@@ -21,5 +21,14 @@
* @param email
*/
{template .ViewChangeButton private="true" autoescape="strict" kind="html"}
- View Change
+ {let $visitButtonStyle kind="css"}
+ background: #4d90fe;
+ border: 1px solid #3079ed;
+ border-radius: 4px;
+ color: #fff;
+ display: inline-block;
+ margin-right: 8px;
+ padding: 6px 12px;
+ {/let}
+ View Change
{/template}