From de540bf17c2d39407419fecac609b14d91582d1e Mon Sep 17 00:00:00 2001
From: Shawn Pearce <sop@google.com>
Date: Wed, 11 Dec 2013 00:49:25 -0800
Subject: [PATCH] ChangeScreen2: Add mouse hover highlight to file table

Some users noted this table is wide and its hard to correlate file
path with size or number of comments when there are many files updated
in a single change.  Add a light blue background under the row the
mouse is hovering on, giving the user a bit more context to find all
related data cells.

Change-Id: I62c81d640c9e17926ccfd8827c89739a7632adba
---
 .../java/com/google/gerrit/client/change/FileTable.java     | 5 +++--
 .../java/com/google/gerrit/client/change/file_table.css     | 6 ++++++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java
index c97418052c..67b5be4bb3 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java
@@ -64,6 +64,7 @@ class FileTable extends FlowPanel {
 
   interface FileTableCss extends CssResource {
     String table();
+    String nohover();
     String pointer();
     String reviewed();
     String status();
@@ -406,7 +407,7 @@ class FileTable extends FlowPanel {
     }
 
     private void header(SafeHtmlBuilder sb) {
-      sb.openTr();
+      sb.openTr().setStyleName(R.css().nohover());
       sb.openTh().setStyleName(R.css().pointer()).closeTh();
       sb.openTh().setStyleName(R.css().reviewed()).closeTh();
       sb.openTh().setStyleName(R.css().status()).closeTh();
@@ -586,7 +587,7 @@ class FileTable extends FlowPanel {
     }
 
     private void footer(SafeHtmlBuilder sb) {
-      sb.openTr();
+      sb.openTr().setStyleName(R.css().nohover());
       sb.openTh().setStyleName(R.css().pointer()).closeTh();
       sb.openTh().setStyleName(R.css().reviewed()).closeTh();
       sb.openTh().setStyleName(R.css().status()).closeTh();
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/file_table.css b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/file_table.css
index c2947cf795..4b695d2265 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/file_table.css
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/file_table.css
@@ -22,6 +22,12 @@
 .table tr {
   vertical-align: top;
 }
+.table tr:hover {
+  background: rgba(209, 245, 248, 0.32);
+}
+.table tr.nohover:hover {
+  background: transparent;
+}
 
 .status {
   padding-right: 4px;