opendev/gerrit
Code Issues Proposed changes

TrivialRebase: Pipe subprocesses directly

Browse Source 
Change-Id: Ic45a8752cb2b6f5a1b85835700658a5cd8127369
This commit is contained in:
Orgad Shaneh
2012-12-31 16:46:08 +02:00
committed by Gerrit Code Review
parent 0ee021b543
commit c9c4272b77
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
contrib/trivial_rebase.py
View File

@@ -142,10 +142,10 @@ class TrivialRebase:
def GetPatchId(self, revision):
git_show_cmd = ['git', 'show', revision]
patch_id_cmd = ['git', 'patch-id']
patch_id_process = subprocess.Popen(patch_id_cmd, stdout=subprocess.PIPE,
stdin=subprocess.PIPE)
git_show_process = subprocess.Popen(git_show_cmd, stdout=subprocess.PIPE)
return patch_id_process.communicate(git_show_process.communicate()[0])[0]
patch_id_process = subprocess.Popen(patch_id_cmd, stdout=subprocess.PIPE,
stdin=git_show_process.stdout)
return patch_id_process.communicate()[0]
def SuExec(self, as_user, cmd):
suexec_cmd = ['ssh', '-l', "Gerrit Code Review", '-p', self.port, self.server, '-i',