opendev/gerrit
Code Issues Proposed changes

Add a Register link when using LDAP authentication

Browse Source 
If auth.type is LDAP Gerrit is responsible for collecting the username
and password and authenticating to the directory.  But we don't have a
way to create new users in the directory, as this is far beyond any
scope we want to handle.

Site administrators might have a URL users can visit to create their
own account, or maybe just want to publish a mailto: link so the user
can request an account to be manually created for them.  Allow those
links to be configured through gerrit.config as auth.registerUrl.

Change-Id: I996ed53c5b80579f3a60cfcf9aebb7940d501366
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-12-16 08:05:27 -08:00
parent ceb96cb38c
commit c9d26b5336
4 changed files with 32 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java
View File

@@ -21,9 +21,7 @@ import com.google.gerrit.reviewdb.Account;
import com.google.gerrit.reviewdb.Project;
import com.google.gerrit.server.account.Realm;
import com.google.gerrit.server.config.AuthConfig;
import com.google.gerrit.server.config.CanonicalWebUrl;
import com.google.gerrit.server.config.GerritServerConfig;
import com.google.gerrit.server.config.Nullable;
import com.google.gerrit.server.config.WildProjectName;
import com.google.gerrit.server.contact.ContactStore;
import com.google.gerrit.server.mail.EmailSender;
@@ -41,7 +39,6 @@ import java.util.Set;
class GerritConfigProvider implements Provider<GerritConfig> {
private final Realm realm;
private final Config cfg;
private final String canonicalWebUrl;
private final AuthConfig authConfig;
private final GitWebConfig gitWebConfig;
private final Project.NameKey wildProject;
@@ -53,12 +50,11 @@ class GerritConfigProvider implements Provider<GerritConfig> {
@Inject
GerritConfigProvider(final Realm r, @GerritServerConfig final Config gsc,
@CanonicalWebUrl @Nullable final String cwu, final AuthConfig ac,
final GitWebConfig gwc, @WildProjectName final Project.NameKey wp,
final SshInfo si, final ApprovalTypes at, final ContactStore cs) {
final AuthConfig ac, final GitWebConfig gwc,
@WildProjectName final Project.NameKey wp, final SshInfo si,
final ApprovalTypes at, final ContactStore cs) {
realm = r;
cfg = gsc;
canonicalWebUrl = cwu;
authConfig = ac;
gitWebConfig = gwc;
sshInfo = si;
@@ -74,7 +70,11 @@ class GerritConfigProvider implements Provider<GerritConfig> {
private GerritConfig create() {
final GerritConfig config = new GerritConfig();
config.setCanonicalUrl(canonicalWebUrl);
switch (authConfig.getAuthType()) {
case LDAP:
config.setRegisterUrl(cfg.getString("auth", null, "registerurl"));
break;
}
config.setUseContributorAgreements(cfg.getBoolean("auth",
"contributoragreements", false));
config.setGitDaemonUrl(cfg.getString("gerrit", null, "canonicalgiturl"));