opendev/gerrit
Code Issues Proposed changes

Change gr-styled-table to be css template

Browse Source 
Previously, gr-styled-table was include in the list view only, which
handled styling the content passed to the list view (which were always
tables of varying content).

Because Polymer2 does not allow for reaching into <slot> to style
content as was done before, the styles have to be imported to the
element that originally creates the content.

Change-Id: I7136f8ccbea00e532d2a8e1a63f6874eb418906e
This commit is contained in:
Becky Siegel
2017-07-14 16:42:38 -07:00
parent c583f720fa
commit c9ec9a16fb
5 changed files with 44 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.html
View File

@@ -19,7 +19,6 @@ limitations under the License.
<link rel="import" href="../../../behaviors/gr-url-encoding-behavior.html">
<link rel="import" href="../../../styles/shared-styles.html">
<link rel="import" href="../../shared/gr-button/gr-button.html">
<link rel="import" href="gr-styled-table.html">
<dom-module id="gr-list-view">
<template>
@@ -69,9 +68,7 @@ limitations under the License.
</gr-button>
</div>
</div>
<gr-styled-table>
<content></content>
</gr-styled-table>
<content></content>
<nav>
<a id="prevArrow"
href$="[[_computeNavLink(offset, -1, itemsPerPage, filter)]]"

77
polygerrit-ui/app/elements/shared/gr-list-view/gr-styled-table.html
View File

@@ -1,77 +0,0 @@
<!--
Copyright (C) 2017 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../../styles/shared-styles.html">
<dom-module id="gr-styled-table">
<template>
<style include="shared-styles">
::content {
display: flex;
flex-direction: column;
}
::content .loading {
display: none;
}
::content #list {
border-collapse: collapse;
width: 100%;
}
::content #list tr.table {
border-bottom: 1px solid #eee;
}
::content #list td {
flex-shrink: 0;
padding: .3em .5em;
}
::content #list th {
background-color: #ddd;
border-bottom: 1px solid #eee;
font-weight: bold;
padding: .3em .5em;
text-align: left;
}
::content #list a {
color: var(--default-text-color);
text-decoration: none;
}
::content #list a:hover {
text-decoration: underline;
}
::content #list .description {
width: 70%;
}
::content #list .loadingMsg {
color: #666;
display: block;
padding: 1em var(--default-horizontal-margin);
}
::content #list .loadingMsg:not(.loading) {
display: none;
}
</style>
<content></content>
</template>
<script>
(function() {
'use strict';
Polymer({
is: 'gr-styled-table',
});
})();
</script>
</dom-module>